#359 Automatically reconnect the EventSource
Merged by abompard. Opened by abompard.
abompard/fedora-hubs reconnecting-eventsource  into  develop

Download 359.patch

In case of server error, the base EventSource object does not reconnect. Use the wrapper provided by https://github.com/fanout/reconnecting-eventsource/ to automatically reconnect the EventSource to the SSE server.

The second commit is a refactoring of the notification icon changes to take the new reconnecting EventSource object into account.

1 new commit added

  • Remove useless debug output

Looks good to me

IMO we should migrate all ^ to ~? So that it does not break with updates?

Looks good to me.

Pull-Request has been merged by abompard

Metadata