just updated the commit to fix the tests that were broken

g.auth should always be defined (that's in hubs.app.check_auth), did you run into a case where it's not defined?

On Fri, 1 Dec 2017 at 8:22 pm, Aurelien Bompard pagure@pagure.io wrote:

abompard commented on the pull-request: Make all parts of hubs require login that you are following:
g.auth should always be defined (that's in `hubs.app.check_auth`), did you run into a case where it's not defined?

Yeah. A couple tests were failing due to it not being defined.

To reply, visit the link below or just reply to this email
https://pagure.io/fedora-hubs/pull-request/477

turns out test_index_logged_out was using app.get(), changing it to check_url() fixes the issue of not having a g.auth when not logged in.

updated the test in the commit, and removed the g.auth defined check in the master template.

I noticed a lot of spaces at the end of some lines in index.html, could you remove them?
FYI in my .vimrc I use this to highlight them:

" Highlight redundant whitespaces and tabs.
highlight RedundantSpaces ctermbg=red guibg=red
match RedundantSpaces /\s\+$\| \+\ze\t/

The tox -e lint command is also giving me an error : ./hubs/tests/views/test_root.py:18:5: E303 too many blank lines (2).

I like the new front page :-)
It says "communication centre", isn't it "center"? Maybe a typo?

Okies! Updated the commit:

• fixed the linting error
• removed extra spaces at the end of lines in index.html
• used en_US spelling of center rather than the en_AU centre