fedora-hubs

#496 Rework of the hub configuration
Merged by abompard. Opened by abompard.
abompard/fedora-hubs feature/rework-hub-config  into  develop

Download 496.patch

This is a big PR that reorganizes the way the hub configuration is stored in the database.
Feel free to read the commits in order, they should be roughly topical.
There is no support for migrating the configuration, so you'll have to remove your DB and run populate.py again.
When this PR is accepted, I'll split the models.py file in multiple sub-modules, because it's getting complicated and I think it would be clearer with a table per file, but I did not want to generate noise for this review.

10 new commits added

  • Fix tests
  • Show config validation errors in the dialog
  • Update widgets to use the new config
  • Add the pagure and github configs
  • Validate some of the config keys
  • Update the config dialog to work with the new schema
  • Add new config keys
  • Redesign the hub config DB schema
  • Only configure the SQLAlchemy metadata if not done before
  • Use Flask signals

rebased onto 6ad0176c2392124581d4157edfc4ad6af06d7d86

I forgot to mention: this PR depends on the "signals" PR, so the first commit actually comes from that branch.

:thumbsup: LGTM!

rebased onto 19922844b12448c312e4db4211add3c6f70cd521

Pull-Request has been merged by abompard
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.