#550 add a mailing list widget for teams
Merged by abompard. Opened by ryanlerch.
ryanlerch/fedora-hubs mailing-list  into  develop

Download 550.patch

This adds a simple mailing list widget for use
on teams page. It shows a list of the 5 most recent
mailing list threads.

mailinglist.png

Is this for testing?

An == comparaison seems more conventional here (both will work).

This is so common we should probably add it to the env filters for all widgets (in hubs/widgets/base.py. However, the others expect a date object (they are defined as lambda d: arrow.get(d).humanize()) and this one expects an Arrow object. This should be uniformized if we register this filter globally.

thanks for the review @abompard!

Have removed the invalidation stuff -- this was indeed for testing purposes -- sorry!

made that comparision == rather than is

Also, i agree with abstracting the humanize stuff out -- do you mind if i do it in a PR after this one, just so i'm not touching a bunch of other widgets in this PR?

rebased onto 0770a8a8ff64ca40cff18838b471047b01445fd1

Could you remove the last horizontal separator? I see you removed it in the CSS but it does not work because the last child of the parent element is actually the <style> tag. Moving that tag to the top works :-)

Also, do we want this widget by default for team hubs? I guess it would make sense since we have the IRC widget by default. Then a message should be displayed if no mailing-list has been configured in the settings.

How about also adding a "Start a new thread" button at the bottom, which would externally link to https://lists.fedoraproject.org/archives/list/<list-address>/message/new ? Like the "Create a new meeting" button for the meetings widget.

rebased onto 0d8da1d4816697288d71ae3a1fd3741e972030cc

Added the message to show if no mailing list has been set.

Also added the new thread button at the bottom. Left the seperator in there (removed that CSS all together) as it looked good with the line at the bottom when the button was added.

rebased onto f67caea896cf609bf4f8d9ab0b2d7d7c33c8b800

rebased onto 6618dc5edbb729c120ce8ca988b400f83c94393a

rebased onto 6618dc5edbb729c120ce8ca988b400f83c94393a

Commit 039f54f8 fixes this pull-request

Pull-Request has been merged by abompard

Pull-Request has been merged by abompard

Metadata