#56 Adds a pagure pull requests widget
Merged by ralph. Opened by dhrish20.
dhrish20/fedora-hubs issue38  into  develop

Download 56.patch
no initial comment

Screenshot:
https://cdn.pbrd.co/images/1XGZ2Spe.png

A couple things seem off here.

  • The 'assignee' is the person assigned to fix the bug. They did not "open" the bug, as the text says here.
  • Odd that their name is a hyperlink to the bug. Should their name be a hyperlink to their hubs page instead?

Should be pagure.io/{repo}/ here, no?

Could this be simplified like:

all_pr.append(dict(
   id=data['requests'][i]['id'],
   title=data['requests'][i]['title'],
   assignee=data['requests'][i]['user']['name'],
))

Screenshot looks very nice! :)

Looks like a great start!

According to threebean: The "opened by" text is actually who the issue was assigned to, so you should change that.

Once you've got that changed, I'll check back in with you.

+1

@ralph I have updated the PR.

I have made changes:
[1] corrected "opened by" and "assigned to"
[2] limited the characters of pr_title to 45 characters

This is the final screenshot now:
https://cdn.pbrd.co/images/2cnlyEQS.png

Looks good! Let's merge it. :)

Thanks @dhrish20!

Metadata