From 6403f106bc7ed7b5c7aad2c9739622c294586ad8 Mon Sep 17 00:00:00 2001 From: Aurélien Bompard Date: Feb 22 2018 10:27:32 +0000 Subject: Issues widget: use local service icons The remote service icons may not be available because of CORS restrictions. --- diff --git a/hubs/widgets/issues/functions.py b/hubs/widgets/issues/functions.py index 2764882..76b4695 100644 --- a/hubs/widgets/issues/functions.py +++ b/hubs/widgets/issues/functions.py @@ -38,7 +38,6 @@ class GetBugzillaBugs(CachedFunction): url=urltmpl.format(issue['id']), updated_at=issue['last_change_time'], service='bugzilla', - icon='https://bugzilla.redhat.com/favicon.ico' )) total_count = len(response['result']['bugs']) return [res, total_count] @@ -90,7 +89,6 @@ class GetPagureIssues(CachedFunction): url=urltmpl.format(issue['project']['url_path'], issue['id']), updated_at=issue['last_updated'], service='pagure', - icon='https://pagure.io/static/favicon.ico' )) total_count = len(response['issues_created'] if author else response['issues_assigned']) @@ -149,7 +147,6 @@ class GetGithubIssues(CachedFunction): url=issue['html_url'], updated_at=issue['updated_at'], service='github', - icon='https://github.com/favicon.ico' )) total_count = response['total_count'] return [res, total_count] diff --git a/js/app/widgets/issues/Issue.js b/js/app/widgets/issues/Issue.js index 173aeab..dc10cff 100644 --- a/js/app/widgets/issues/Issue.js +++ b/js/app/widgets/issues/Issue.js @@ -5,6 +5,7 @@ import PropTypes from "prop-types"; export default class Issue extends React.Component { render() { + const icon = require(`./${this.props.issue.service}.png`); return (
  • @@ -18,7 +19,7 @@ export default class Issue extends React.Component {
    {this.props.issue.project}