Issue #10338: bodhi issue with side-tag updates, need help to push security updates - fedora-infrastructure

fedora-infrastructure

#10338 bodhi issue with side-tag updates, need help to push security updates

Closed: Fixed Nov 17, 2021 by kevin. Opened Nov 15, 2021 by abbra.

We have three security updates for samba and freeipa which stuck in bodhi not being able to push them. These three updates were built in side-tags and re-built several times as we were finding regressions.

F33: https://bodhi.fedoraproject.org/updates/FEDORA-2021-218ec2d434
F34: https://bodhi.fedoraproject.org/updates/FEDORA-2021-1d77047c61
F35: https://bodhi.fedoraproject.org/updates/FEDORA-2021-12af2614da

In all cases, bodhi does not understand the side-tag inheritance and cannot get freeipa from the side-tag. Below is a F35 example:

FEDORA-2021-12af2614da ejected from the push because "Cannot find relevant tag for freeipa-4.9.7-4.fc35. None of ['f35-build-side-47610'] are in ['epel9-next-testing-candidate', 'epel7-testing-candidate', 'dist-5E-epel-testing-candidate', 'f27-modular-updates-candidate', 'f34-container-updates-candidate', 'eln-updates-candidate', 'f30-modular-updates-candidate', 'f28-modular-updates-candidate', 'f28-container-updates-candidate', 'f30-container-updates-candidate', 'epel8-testing-candidate', 'f30-flatpak-updates-candidate', 'f35-container-updates-candidate', 'f32-modular-updates-candidate', 'f29-modular-updates-candidate', 'f29-container-updates-candidate', 'f29-flatpak-updates-candidate', 'f22-updates-candidate', 'f21-updates-candidate', 'f25-updates-candidate', 'f24-updates-candidate', 'f23-updates-candidate', 'f26-updates-candidate', 'f31-modular-updates-candidate', 'dist-6E-epel-testing-candidate', 'f32-flatpak-updates-candidate', 'f35-flatpak-updates-candidate', 'f27-updates-candidate', 'f28-updates-candidate', 'f30-updates-candidate', 'f29-updates-candidate', 'el8-modular-updates-candidate', 'f32-updates-candidate', 'f33-updates-candidate', 'f33-modular-updates-candidate', 'f33-container-updates-candidate', 'f33-flatpak-updates-candidate', 'f31-updates-candidate', 'f31-container-updates-candidate', 'f31-flatpak-updates-candidate', 'f34-updates-candidate', 'f34-modular-updates-candidate', 'f34-flatpak-updates-candidate', 'f36-container-updates-candidate', 'f32-container-updates-candidate', 'epel8-next-testing-candidate', 'f35-updates-candidate', 'f35-modular-updates-candidate', 'f36-updates-candidate']."

I think the reason is that get_tags API in bodhi cannot understand inheritance and that a side-tag should be expanded: https://github.com/fedora-infra/bodhi/blob/211d80264f6ae948a83b65ae3a9ed8cf9826fe2d/bodhi/server/models.py#L947 but in this particular case I just need the three Bodhi updates to be pushed so a solution to re-tag the builds would help as well.

mohanboddu commented Nov 15, 2021

This should be fixed now, lets wait and see what happens in the next push.

Metadata Update from @mohanboddu:
- Issue assigned to mohanboddu
- Issue priority set to: Waiting on Assignee (was: Needs Review)
- Issue tagged with: medium-gain, medium-trouble, ops

Nov 15, 2021

kevin commented Nov 17, 2021

They all appear to have successfully pushed to testing now.

Please let us know if there's anything further we can do.

Metadata Update from @kevin:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

Nov 17, 2021

mattia commented Nov 17, 2021

I think I've messed things up in the last Bodhi release:
https://github.com/fedora-infra/bodhi/issues/4284

Sorry about that.

kevin commented Nov 18, 2021

It happens. :(

Just let us know when there's a fix and we can roll out a new version.