#37 If no search backend, make index the main page
Closed by ryanlerch. Opened by abitrolly.
abitrolly/fedora-packages-static configurable-urlscheme  into  master

Download 37.patch

When there is no backed, the search form on the main page is useless.

This is how it looks after this commit https://abitrolly.github.io/fedora-packages-static/

Could this be simplified to main_is_static = not SEARCH_BACKEND?

"The plan" is to add static search like that one that powers https://www.piwheels.org/packages.html and it will be confusing to say that there is no search backend, or name it "search frontend".

The logic is that main_is_static is not necessarily the inverse of SEARCH_BACKEND.

I'm thinking that either it should be made clear that SEARCH_BACKEND only refers to enabling Solr (rename to SOLR_SEARCH_MODE or similar) or keeping SEARCH_BACKEND and setting it to a string depending on which "backend" or "search mode" is being used ('js' or 'solr', then main_is_static = SEARCH_BACKEND == 'js').

SEARCH_BACKEND = 'solr' yes, but it is premature to add it at his point. main_is_static = SEARCH_BACKEND != 'solr' in plain English still reads strange.

fedora-pages-static has been migrated to Fedora Forge.

this ticket has also been migrated, please continue over at

https://forge.fedoraproject.org/apps/fedora-packages-static/issues/37

Pull-Request has been closed by ryanlerch

Metadata