fedora-packages-static

#9 Genarate static index for packages
Merged by mymindstorm. Opened by abitrolly.
abitrolly/fedora-packages-static master  into  master

Download 9.patch

This makes the project useful without dynamic search backend. I didn't have time to polish all commits yet to push it before weekend.

Browsable on https://abitrolly.github.io/fedora-packages-static/

Looks good! A few changes would be appreciated:

  • Could you move the static index to a link under the main index?
  • Remove dependencies.txt, requirements should be in the readme.
  • Remove the github file
  • Please fix your commit history
Edited by mymindstorm

The latest code of https://abitrolly.github.io/fedora-packages-static/ is on https://github.com/abitrolly/fedora-packages-static and I can't remove GitHub files, because I use them for publishing what you see. Pagure doesn't provide any alternative to keep these pages available.

Could you move the static index to a link under the main index?

Can you post a screen of what do you mean?

Remove dependencies.txt, requirements should be in the readme.
Please fix your commit history

Before I invest more of my free time into this, it would be nice to see the decision if the dynamic parts of the repo are going by removed now that there is true usable static version, or if the repo will be renamed to reflect that the search doesn't work.

As you see on https://abitrolly.github.io/fedora-packages-static/ the search form is gone.

The latest code of https://abitrolly.github.io/fedora-packages-static/ is on https://github.com/abitrolly/fedora-packages-static and I can't remove GitHub files, because I use them for publishing what you see. Pagure doesn't provide any alternative to keep these pages available.

That's downstream for us - you're free to have them on your side, but github-specific configuration has nothing to do here.

Could you move the static index to a link under the main index?

Add a link next to Back to the application index ↵ on the front page (the one with a search field).

Before I invest more of my free time into this, it would be nice to see the decision if the dynamic parts of the repo are going by removed now that there is true usable static version, or if the repo will be renamed to reflect that the search doesn't work.

We can add a flag to hide the dynamic search field if you want to use this project in a purely static way, but we won't drop the search feature (= we implemented it for a reason).

Why not rename this repo to just fedora-packages-3? Which reincarnation
is it, BTW?

This repository name and URL have been used in various places over the last months, and I'm completly fine with this name anway. From my point of view changing it will just be painful for various people.

As for the history: the original app was killed along the recent datacenter move. I started to work on this project a few weeks after said move and Bredan took over my POC (many thanks to him). There's also another dynamic POC out there, but It does not seem it'll be used. More on the infra list archives.

rebased onto a96d1a776c765ee4bf8bdd97a23de729da189dcb

I removed GitHub actions from the history.

Do you want the link to https://abitrolly.github.io/fedora-packages-static/ or how do you want it to look like?

Having it link to the former looks good, but you need to change the CSS to be in line with the current changes so that it looks fine on smaller devices (i.e. use .container instead of .page and restrict the width using other bootstrap classes/breakpoints). Instead of hiding or showing the search bar in response to SEARCH_BACKEND, you could just use the package index page over the search page as the website's index depending on the value because of this change.

"Static Index" should probably be black due to being the primary header for the page.

The logo image should link to the website's index page

text needs to be capitalized properly. You could even add the prefix to the like <code>Packages Starting with cu - Fedora Packages</code></p> <p>There are some merge conflicts, so you will need to fix that.</p></span> </div> </section> </div> <div class="card-footer bg-transparent d-flex align-items-center border-0 p-0"> <div class="issue_reactions ml-auto" data-comment-id="150409"> <div class="btn-group"> </div> </div> </div> </div> <div class="d-flex align-items-center px-3 py-2 mb-3"> <div class=""> </div> <span class="font-size-09 autogenerated-comment pl-4"><p>rebased onto e64d902481a6ee933cf101fc4fc6e28d30e08ea3</p></span> <div class="text-muted ml-auto"> <time class="relative-date" datetime="2021-05-31T08:32:59Z" title="2021-05-31T08:32:59Z" data-toggle="tooltip">May 31, 2021</time> </div> </div> <div class="d-flex align-items-center px-3 py-2 mb-3"> <div class=""> </div> <span class="font-size-09 autogenerated-comment pl-4"><p><strong>1 new commit added</strong></p> <ul> <li><code>Fix for new style changes</code></li> </ul></span> <div class="text-muted ml-auto"> <time class="relative-date" datetime="2021-05-31T09:27:57Z" title="2021-05-31T09:27:57Z" data-toggle="tooltip">May 31, 2021</time> </div> </div> <div class="card mb-4 clearfix"> <div id="comment-150436" class="card-header bg-light d-flex align-items-center px-3 py-2"> <div> <span class="font-weight-bold" title="">abitrolly</span> <a class="notblue" title="Permalink to this headline" href="#comment-150436"> <span title="2021-05-31 11:39:04 UTC">commented <time class="relative-date" datetime="2021-05-31T11:39:04Z" title="2021-05-31T11:39:04Z" data-toggle="tooltip">May 31, 2021</time></span> </a> </div> <div class="issue_actions ml-auto"> <div class="issue_action icon"> <div class="btn-group" role="group" aria-label="Basic example"> </div> </div> </div> </div> <div class="card-body pb-1"> <section class="issue_comment"> <div> <span class="edit_date" title="2021-05-31 15:39:20 UTC"> </span> <span class="comment_text comment_body"><p>Resolved merge conflicts and made title black again.</p> <p>I am not skilled in design / CSS / bootstrap enough to know what needs to be done there. Just copied index markup changes to my own template.</p> <p>What is left.</p> <ul> <li>[x] generate static index in a separate page</li> <li>[ ] use status index page as main if no search backend</li> <li>[x] add backlink to static index page</li> <li>[x] add links to logos</li> <li>[x] add prefix to index page titles</li> </ul></span> </div> </section> </div> <div class="card-footer bg-transparent d-flex align-items-center border-0 p-0"> <div class="issue_actions ml-3"> <small>Edited <time class="relative-date" datetime="2021-05-31T15:39:20Z" title="2021-05-31T15:39:20Z" data-toggle="tooltip">May 31, 2021</time> by abitrolly </small> </div> <div class="issue_reactions ml-auto" data-comment-id="150436"> <div class="btn-group"> </div> </div> </div> </div> <div class="d-flex align-items-center px-3 py-2 mb-3"> <div class=""> </div> <span class="font-size-09 autogenerated-comment pl-4"><p><strong>1 new commit added</strong></p> <ul> <li><code>Make primary header black again</code></li> </ul></span> <div class="text-muted ml-auto"> <time class="relative-date" datetime="2021-05-31T11:39:25Z" title="2021-05-31T11:39:25Z" data-toggle="tooltip">May 31, 2021</time> </div> </div> <div class="d-flex align-items-center px-3 py-2 mb-3"> <div class=""> </div> <span class="font-size-09 autogenerated-comment pl-4"><p><strong>1 new commit added</strong></p> <ul> <li><code>Link logo to website root from index pages</code></li> </ul></span> <div class="text-muted ml-auto"> <time class="relative-date" datetime="2021-05-31T11:57:03Z" title="2021-05-31T11:57:03Z" data-toggle="tooltip">May 31, 2021</time> </div> </div> <div class="d-flex align-items-center px-3 py-2 mb-3"> <div class=""> </div> <span class="font-size-09 autogenerated-comment pl-4"><p><strong>1 new commit added</strong></p> <ul> <li><code>Add `layout.html.j2` and use it for static indexes</code></li> </ul></span> <div class="text-muted ml-auto"> <time class="relative-date" datetime="2021-05-31T13:41:04Z" title="2021-05-31T13:41:04Z" data-toggle="tooltip">May 31, 2021</time> </div> </div> <div class="d-flex align-items-center px-3 py-2 mb-3"> <div class=""> </div> <span class="font-size-09 autogenerated-comment pl-4"><p><strong>1 new commit added</strong></p> <ul> <li><code>Generate static index on a separate page</code></li> </ul></span> <div class="text-muted ml-auto"> <time class="relative-date" datetime="2021-05-31T15:38:48Z" title="2021-05-31T15:38:48Z" data-toggle="tooltip">May 31, 2021</time> </div> </div> <div class="card mb-4 clearfix"> <div id="comment-150459" class="card-header bg-light d-flex align-items-center px-3 py-2"> <div> <span class="font-weight-bold" title="">abitrolly</span> <a class="notblue" title="Permalink to this headline" href="#comment-150459"> <span title="2021-05-31 17:53:11 UTC">commented <time class="relative-date" datetime="2021-05-31T17:53:11Z" title="2021-05-31T17:53:11Z" data-toggle="tooltip">May 31, 2021</time></span> </a> </div> <div class="issue_actions ml-auto"> <div class="issue_action icon"> <div class="btn-group" role="group" aria-label="Basic example"> </div> </div> </div> </div> <div class="card-body pb-1"> <section class="issue_comment"> <div> <span class="edit_date" title=""> </span> <span class="comment_text comment_body"><p>This should be fine with dynamic backend enabled. It makes static index a separate page.</p></span> </div> </section> </div> <div class="card-footer bg-transparent d-flex align-items-center border-0 p-0"> <div class="issue_reactions ml-auto" data-comment-id="150459"> <div class="btn-group"> </div> </div> </div> </div> <div class="d-flex align-items-center px-3 py-2 mb-3"> <div class=""> </div> <span class="font-size-09 autogenerated-comment pl-4"><p>rebased onto 90c1263d59989363ce47468adbc288d4b1a44d27</p></span> <div class="text-muted ml-auto"> <time class="relative-date" datetime="2021-06-05T19:59:42Z" title="2021-06-05T19:59:42Z" data-toggle="tooltip">Jun 5, 2021</time> </div> </div> <div class="card mb-4 clearfix"> <div id="comment-150785" class="card-header bg-light d-flex align-items-center px-3 py-2"> <div> <span class="font-weight-bold" title="">mymindstorm</span> <a class="notblue" title="Permalink to this headline" href="#comment-150785"> <span title="2021-06-05 20:20:16 UTC">commented <time class="relative-date" datetime="2021-06-05T20:20:16Z" title="2021-06-05T20:20:16Z" data-toggle="tooltip">Jun 5, 2021</time></span> </a> </div> <div class="issue_actions ml-auto"> <div class="issue_action icon"> <div class="btn-group" role="group" aria-label="Basic example"> </div> </div> </div> </div> <div class="card-body pb-1"> <section class="issue_comment"> <div> <span class="edit_date" title=""> </span> <span class="comment_text comment_body"><p>Going to test and merge this today. Due to the planned changes with how source packages are handled (see mailing list for context, changing url scheme to <code>/pkgs/<source pkg>/<subpackage></code>), we will need to decide how to represent them in this index. I.e. do we list:</p> <ol> <li>Source packages only</li> <li>Built packages only (current)</li> <li>Source packages and built packages (but make sure to de-duplicate)</li> <li>Source packages, but group built packages under the source package</li> </ol> <p>I think it can be kept as two for the time being. Thoughts?</p></span> </div> </section> </div> <div class="card-footer bg-transparent d-flex align-items-center border-0 p-0"> <div class="issue_reactions ml-auto" data-comment-id="150785"> <div class="btn-group"> </div> </div> </div> </div> <div class="d-flex align-items-center px-3 py-2 mb-3"> <div class=""> </div> <span class="font-size-09 autogenerated-comment pl-4"><p>Pull-Request has been merged by mymindstorm</p></span> <div class="text-muted ml-auto"> <time class="relative-date" datetime="2021-06-05T20:42:07Z" title="2021-06-05T20:42:07Z" data-toggle="tooltip">Jun 5, 2021</time> </div> </div> <div class="card mb-4 clearfix"> <div id="comment-150793" class="card-header bg-light d-flex align-items-center px-3 py-2"> <div> <span class="font-weight-bold" title="">abitrolly</span> <a class="notblue" title="Permalink to this headline" href="#comment-150793"> <span title="2021-06-06 18:35:43 UTC">commented <time class="relative-date" datetime="2021-06-06T18:35:43Z" title="2021-06-06T18:35:43Z" data-toggle="tooltip">Jun 6, 2021</time></span> </a> </div> <div class="issue_actions ml-auto"> <div class="issue_action icon"> <div class="btn-group" role="group" aria-label="Basic example"> </div> </div> </div> </div> <div class="card-body pb-1"> <section class="issue_comment"> <div> <span class="edit_date" title=""> </span> <span class="comment_text comment_body"><p>To check if some software is packaged for Fedora, I'd leave only binary packages. Although the "source package" concept is historically important, it could be just a link to "packaging sources". I believe such naming doesn't require learning new concept, or unlearning that "Fedora package" is not a final term.</p></span> </div> </section> </div> <div class="card-footer bg-transparent d-flex align-items-center border-0 p-0"> <div class="issue_reactions ml-auto" data-comment-id="150793"> <div class="btn-group"> </div> </div> </div> </div> </form> </section> </div> <div class="col-md-4"> <div> <div class="mb-4"> <h5 class="d-flex align-items-center font-weight-bold border-bottom"> <div class="py-2 text-uppercase font-size-09">Metadata</div> </h5> <fieldset class="form-group issue-metadata-display ml-1"> <label class="mb-1 pl-1"> <i class="fa fa-fw fa-user-plus"></i> <strong>Assignee</strong></label> <div id="assignee_plain"> <div class="ml-2" title=""> <div class="text-muted"> <span class="text-muted">None</span> </div> </div> </div> </fieldset> <fieldset class="form-group issue-metadata-display ml-1"> <label class="mb-0"><strong>Tags</strong></label> <div class="text-muted">No Tags</div> </fieldset> </div> </div> </div> </div> </div> </div> </div> <div class="footer pt-4 pb-5 text-white"> <div class="container"> <div class="row mb-4 pb-3 border-bottom" style="border-color: rgba(255,255,255,0.25) !important;"> <div class="col text-center"> <strong>Static archive.</strong> pagure.io was sunset in 2026; this is a read-only snapshot. </div> </div> <div class="d-flex justify-content-between align-items-center flex-wrap pt-4"> <div class="flex-shrink-0"> <a href="https://www.redhat.com/" class="d-inline-block"> <img src="https://fedoraproject.org/assets/images/logo-sponsored-by-red-hat.png" alt="Red Hat Logo" class="img-fluid" style="max-height: 48px;"> </a> </div> <div class="text-right flex-grow-1 mt-2 mt-md-0"> <p class="my-2 mb-0">Fedora is sponsored by Red Hat. <a href="https://www.redhat.com/en/technologies/linux-platforms/articles/relationship-between-fedora-and-rhel" class="text-white text-decoration-underline">Learn more about the relationship between Red Hat and Fedora »</a></p> <p class="my-2 mb-0">© Red Hat, Inc. and others.</p> </div> </div> </div> </div> <script type="text/javascript" nonce="dev-nonce" src="/static/vendor/jquery/jquery.min.js?version=1.0.0"></script> <script src="/static/vendor/bootstrap/bootstrap.bundle.min.js?version=1.0.0"></script> <script type="text/javascript" nonce="dev-nonce" src="/static/pagure-common.js?version=1.0.0"></script> <script type="text/javascript" nonce="dev-nonce" src="/static/pagure-relative-dates.js?version=1.0.0"></script> </body> </html>