#42 Opt-in for python3
Merged by zuul. Opened by churchyard.
churchyard/fedora-project-config python3  into  master

Download 42.patch

I have followed https://fedoraproject.org/wiki/Zuul-based-ci#Configure_the_repository_for_Zuul except I haven't added the zuul account as a committer. I suppose that should not be needed to test things, if we don't want to use the "gateit" tag workflow yet.

Let me know if that is actually needed even to test PRs.

Build failed.

Traceback (most recent call last):
  File "/usr/bin/managesf-resources", line 10, in <module>
    sys.exit(cli())
  File "/usr/lib/python3.6/site-packages/managesf/cmds/resources.py", line 242, in cli
    args.zuul_prev_commit, args.zuul_commit)
  File "/usr/lib/python3.6/site-packages/managesf/cmds/resources.py", line 76, in read_repo_to_validate
    print(head_commit_msg)
UnicodeEncodeError: 'ascii' codec can't encode character '\u010d' in position 65: ordinal not in range(128)

That's č in my name (git commit author) if that helps.

recheck

oops, I added an encode errors 'ignore' quick fix

recheck

Build failed.

recheck

Build succeeded.

For the record, here is the quickfix we deployed: https://softwarefactory-project.io/r/17378

@churchyard would you like to get this change merged and applies now?

For the record, here is the quickfix we deployed: https://softwarefactory-project.io/r/17378

Would running the proces with an UTF-8 locale set be a proper fix? prinitng unicode strings should work if the locale supports it, such as C.UTF-8 (or en_US.UTF-8 on older systems such as EL7).

And yes, I want this PR merged, so I can test the zuul CI on existing PRs: https://src.fedoraproject.org/rpms/python3/pull-requests

Metadata Update from @tdecacqu:
- Pull-request tagged with: gateit

Yes, we should look into why the executor doesn't enable unicode locals. In the meantime let's move on with this PR.

Build succeeded (gate pipeline).

Pull-Request has been merged by zuul

Metadata