fedora-qa / landingpage

#17 Removed lodash and added uniqueID fn
Merged by lbrabec. Opened by manishakanyal.
fedora-qa/ manishakanyal/landingpage Remove_lodash  into  master

Download 17.patch

Removed lodash and added uniqueID fn.

Used nanoid for uniqueID generation and ramda for other lodash functions.

Fixes: https://pagure.io/fedora-qa/landingpage/issue/11

Lodash is still used in src/wizard/Actions.js and src/wizard/WizardForm.js.

Please remove lodash from there and replace it with ramda.

I missed that somehow. I'll push the code soon.

1 new commit added

  • removed existing lodash usage

@lbrabec please have a look once.

Metadata Update from @lbrabec:
- Pull-request tagged with: review in progress

Looks good!

Please squash commits and rebase on current master, thansk.

@lbrabec, Great! Moving ahead!

rebased onto 9d832076c02139f96f2aacc31b5ff38642bd9e2d

rebased onto bf7a9981985fa719e271b5e4299f13a81d625dbd

@lbrabec, Does this look good or I messed up something?
Please let me know so that I can make amendments if needed.

Commits are not squashed, please use git rebase -i <commit hash>, where <commit hash> is a hash of commit after which you want to squash. In this case it will be hash of commit "SourceLink component is added"

rebased onto 9d832076c02139f96f2aacc31b5ff38642bd9e2d

@lbrabec, It's showing-> 

git rebase -i b743bedebf350adb88523424efae3d05f3a6f59d
Successfully rebased and updated refs/heads/Remove_lodash.
git push origin Remove_lodash 
Everything up-to-date

Did anything go wrong?

Did you change "pick" to "squash" on commit(s) you want to squash when prompted after running the rebase command?

2 new commits added

  • Merge branch 'Remove_lodash' of ssh://pagure.io/forks/manishakanyal/fedora-qa/landingpage into Remove_lodash
  • Squashed Commits of removing lodash.

rebased onto bf7a9981985fa719e271b5e4299f13a81d625dbd

rebased onto 448131ea3e767a7aec1ed4b1307109d76ac1e6e8

@lbrabec, I guess it's good to go. Can you check once, please?
Learned a new lesson today :)
Edited by manishakanyal

Looks good, thanks!

Metadata Update from @lbrabec:
- Pull-request untagged with: review in progress
- Pull-request tagged with: review done

rebased onto 14f79711ef97d960b3bdf74ca577c8371c5f18b3

Pull-Request has been merged by lbrabec
Metadata
None

review done

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.