#38 Project Structure modification and code splitting
Closed by lbrabec. Opened by divyanshisingh.
fedora-qa/ divyanshisingh/landingpage project-structure-modification  into  master

Download 38.patch

In continuation to my PR https://pagure.io/fedora-qa/landingpage/pull-request/31, this PR addresses the following issues as mentioned by me in (#8) https://pagure.io/fedora-qa/landingpage/issue/8#comment-724084
1) Implemented reusable components to clean up the parent components.
2) Changed folder structure.

1 new commit added

  • common api function, http error handling

1 new commit added

  • wizard component

Hey, @lbrabec can you please review this structure and give me your feedback.

Metadata Update from @lbrabec:
- Pull-request tagged with: review in progress

Project structure looks good.

Please rebase this branch so it uses the commit 8388eaf from #31

2 new commits added

  • rebased
  • redux toolkit implemented

I have rebased my branch.

Any updates @lbrabec

@divyanshisingh Hi, it seems like you got a bit overzealous with the rebasing and commit history restructuring.

I suspect this somewhat comes from the way Pagure throws the wrench into things, combined with the fact that your previous that this one is supposed to be "build upon" PR (#31) is not yet merged.

After carefully inspecting your code, it looks fine, but the commits are just terribly intermingled.

Based on the way your GIT repo looks (here in pagure, not sure about your local machine, of coutse), I suggest following these steps to get a reasonable, working PR:

In your terminal/git bash/whatever console you use for git, go to the directory your git checkout of the landingpage project and run the following:

git checkout  redux-toolkit-reducer-config
git checkout -b project-structure-modification-cleanup
git checkout project-structure-modification
git diff redux-toolkit-reducer-config > ./psmchanges.diff
git checkout project-structure-modification-cleanup
git apply ./psmchanges.diff
rm ./psmchanges.diff
git add -A
git commit -m "Project Structure modification and code splitting"
git push --set-upstream origin project-structure-modification-cleanup

That should give you a new branch in your repo called project-structure-modification-cleanup with the changes from this PR neatly squashed into one commit, and based on the code from the #31.

Once you have that, create a new PR and close this one.

Thanks!

Thanks for PR.

I'll close this one as it incompatible with current code base.

Pull-Request has been closed by lbrabec

Metadata