I can't verify the details on this myself offhand, but it looks right at the high level. Thank you so much for diving into this!
I applied the patch on a local checkout and I get three issues on the Cloud Atomic download page:
Is this an issue with the globals somewhere, or something else missing? Something I'm failing to do in testing?
@pfrields, I think issues number 1 and 2 are just hiccups. Those work for me locally.
I think issue #3 is actually an issue though, but it is a pre-existing one. AFAIK, we've never known what to do with that rightmost bar. There may have been some plan for it that never bore fruit.
Yeah, here are my logs from the build process. @pfrields, do you need to make veryclean?
make veryclean
INFO:atomic_vars:Looking for latest atomic release for 24 INFO:requests.packages.urllib3.connectionpool:Starting new HTTPS connection (1): apps.fedoraproject.org INFO:atomic_vars: Found composedate: 20160712.0 INFO:requests.packages.urllib3.connectionpool:Starting new HTTPS connection (1): dl.fedoraproject.org INFO:requests.packages.urllib3.connectionpool:Starting new HTTPS connection (1): dl.fedoraproject.org INFO:requests.packages.urllib3.connectionpool:Starting new HTTPS connection (1): dl.fedoraproject.org INFO:requests.packages.urllib3.connectionpool:Starting new HTTPS connection (1): dl.fedoraproject.org INFO:fedimg_vars:Looking for AMIs for Fedora-Cloud-Base-24-20160616.n.0.x86_64 INFO:requests.packages.urllib3.connectionpool:Starting new HTTPS connection (1): apps.fedoraproject.org INFO:fedimg_vars:Looking for AMIs for Fedora-Atomic-24-20160712.0.x86_64 INFO:atomic_vars:Looking for latest atomic release for 24 INFO:atomic_vars: Found composedate: 20160712.0 INFO:requests.packages.urllib3.connectionpool:Starting new HTTPS connection (1): dl.fedoraproject.org INFO:requests.packages.urllib3.connectionpool:Starting new HTTPS connection (1): dl.fedoraproject.org INFO:requests.packages.urllib3.connectionpool:Starting new HTTPS connection (1): dl.fedoraproject.org INFO:requests.packages.urllib3.connectionpool:Starting new HTTPS connection (1): dl.fedoraproject.org
The fixes are working fine, but we need to make sure the images are synched out to the mirrors. Also, we are missing the Atomic Iso installer, in alt/atomic/stable I can find only a Fedora-Atomic-dvd.
Fianlly, we need to revert also commit 5ae1792ee23e2a5c8ee745395211c6fde685e0d9 and 1fb82e9ee64b5008ca6fd99ea5b1a930b1e21364, dropping also the 32 bit checksum part.
All the rest looks good to me.
The fixes are working fine, but we need to make sure the images are synched out to the mirrors. Also, we are missing the Atomic Iso installer, in alt/atomic/stable I can find only a Fedora-Atomic-dvd. Fianlly, we need to revert also commit 5ae1792ee23e2a5c8ee745395211c6fde685e0d9 and 1fb82e9ee64b5008ca6fd99ea5b1a930b1e21364, dropping also the 32 bit checksum part. All the rest looks good to me.
When you say "we are missing the Atomic ISO installer" what are you referring to other than the Fedora-Atomic-DVD?
I think the conversation has moved on already so I don't mean to be a pain. I did try make veryclean but it didn't make a difference for me.
Pull-Request has been merged by robyduck