#846 [getfedora.org] rework the atomic downloads page
Merged by sinnykumari. Opened by ryanlerch.
Unknown source master

Download 846.patch

Here is a solution for cleaning up the Downloads page of the Atomic section, as requested in:

  • https://pagure.io/atomic-wg/issue/389
  • https://pagure.io/fedora-websites/issue/828

It works now at mobile sizes too without having to have separate sections in there. Will need the Atomic folks to review this too.

@dustymabe @sinnykumari

atomic-downloads.gif

Okies, forgot to work in the multi-arch stuff here...

Will update in a second

OKies, amended the commit. the bottom atomic images section now has spots for all the arches:

atomic-downloads2.gif

rebased onto 6c472c27302f4c005617b219a685ce378da40a90

Thanks a lot @ryanlerch
New design looks awesome to me including multi-arch content. In current atomic download page, when we click on a media to download e.g. qcow2, it takes us to a new page where have button to verify qcow2 media checksum.
Can we have something for media checksum in new design as well?

@sinnykumari at the moment there just seems to be one checksum file:

https://dl.fedoraproject.org/pub/alt/atomic/stable/Fedora-Atomic-28-20180528.0/AtomicHost/x86_64/images/

https://dl.fedoraproject.org/pub/alt/atomic/stable/Fedora-Atomic-28-20180528.0/AtomicHost/x86_64/images/Fedora-AtomicHost-28-20180528.0-x86_64-CHECKSUM

will there be checksums for the others too? and in seperate files? or all the same checksum file?

hey ryan. this looks awesome. Only issue I see is that the "ISO download" is under the "Cloud Images" section. Maybe we need another section for that for "Bare metal".

hey ryan. this looks awesome. Only issue I see is that the "ISO download" is under the "Cloud Images" section. Maybe we need another section for that for "Bare metal".

@dustymabe Would it work to change the title of "Atomic Host Images for Cloud Environments" to something else, maybe just "Atomic Host Images"?

@dustymabe Would it work to change the title of "Atomic Host Images for Cloud Environments" to something else, maybe just "Atomic Host Images"?

Maybe.. the only thing I don't like about that is all of the other sections have a "For XYZ" as part of their description. I think optimally there would be a "Atomic Host Images for Cloud Environments" and a "Atomic Host Images for Bare Metal" section. If it's a lot of work then don't worry about it and we can just go with "Atomic Host Image Downloads" or something.

@sinnykumari at the moment there just seems to be one checksum file:
https://dl.fedoraproject.org/pub/alt/atomic/stable/Fedora-Atomic-28-20180528.0/AtomicHost/x86_64/images/
https://dl.fedoraproject.org/pub/alt/atomic/stable/Fedora-Atomic-28-20180528.0/AtomicHost/x86_64/images/Fedora-AtomicHost-28-20180528.0-x86_64-CHECKSUM
will there be checksums for the others too? and in seperate files? or all the same checksum file?

Yes, there are separate checksum file for each arch:
aarch64 images - https://dl.fedoraproject.org/pub/alt/atomic/stable/Fedora-Atomic-28-20180528.0/AtomicHost/aarch64/images/Fedora-AtomicHost-28-20180528.0-aarch64-CHECKSUM
ppc64le images - https://dl.fedoraproject.org/pub/alt/atomic/stable/Fedora-Atomic-28-20180528.0/AtomicHost/ppc64le/images/Fedora-AtomicHost-28-20180528.0-ppc64le-CHECKSUM

Also, separate checksum file for iso on each arch:
x86_64 - https://dl.fedoraproject.org/pub/alt/atomic/stable/Fedora-Atomic-28-20180528.0/AtomicHost/x86_64/iso/Fedora-AtomicHost-28-20180528.0-x86_64-CHECKSUM
ppc64le - https://dl.fedoraproject.org/pub/alt/atomic/stable/Fedora-Atomic-28-20180528.0/AtomicHost/ppc64le/iso/Fedora-AtomicHost-28-20180528.0-ppc64le-CHECKSUM
aarch64 - https://dl.fedoraproject.org/pub/alt/atomic/stable/Fedora-Atomic-28-20180528.0/AtomicHost/aarch64/iso/Fedora-AtomicHost-28-20180528.0-aarch64-CHECKSUM

@ryanlerch What are your thoughts on where to fit in image checksums?

We now have multi-arch content in atomic twoweek fedmsg - https://apps.fedoraproject.org/datagrepper/id?id=2018-d8b306e6-f070-4431-9389-7ad11f59a493&is_raw=true&size=extra-large
It will be nice to have atomic download page updated as well with multi-arch content.

@ryanlerch Can we please have the rest of stuff done which is required to get this PR merged?

rebased onto e2dd97331ebd73b0f97448effa78761115748ae9

rebased onto 26262426131dbc14db8cd76b910f81d4c12e75e0

@sinnykumari OKies! got the multi-arch links all working!

@dustymabe added the new bare metal section too.

Tested it locally and multi-arch download links work perfectly fine for both cloud images and isos. Thanks @ryanlerch !

@ryanlerch Can we do something for validating (Checksum ) media as well in new UI?

rebased onto b45c6ad21f94e64968f835221872abe7902ebc7f

This comment should not be needed now because we get size of file from twoweek fedmsg data (line 53) instead of using HTTP HEAD.

If we want to print results value, it will be good to add as log.info()

Checksum url path contains lowercase as ppc64le instead of PPC64le. Something like- ${global_variables.path['download_atomic']}/stable/Fedora-Atomic-${global_variables.release['curr_atomic_id']}-${global_variables.release['atomic_composedate']}/AtomicHost/ppc64le/images/Fedora-AtomicHost-${global_variables.release['curr_atomic_id']}-${global_variables.release['atomic_composedate']}-ppc64le-CHECKSUM

For consistency, let's keep PPC64le also as lowercase in style.

Thank you so much @ryanlerch . Added few minor comments, other than that it looks good to me.

rebased onto 7cb620685e24ae4daa5bdad01ceacf85cb4483b3

Updated, removed the HTTP Head comment.

The print statement is removed also. This was just debugging that i left in there mistakenly.

changes the two strings to ppc64le lowercase.

@sinnykumari are we right to go live on this one once you approve the final tweaks above?

@ryanlerch +1 from me to merge this PR.
@dustymabe @robyduck Would you like to do a final review of this PR before we merge it?

@sinnykumari I'm +1 if you are :)

Pull-Request has been merged by sinnykumari

Metadata