LGTM, but in my experience, if I have multiline changelog, it is not formatted appropriately, or is it?

@vondruch Can you give an example that is malformed?

This is example from vagrant-libvirt f25 branch:

[ vagrant-libvirt-0.0.35-4.fc25 ]
# bugfix, security, enhancement, newpackage (required)
type=
# testing, stable
request=testing
# Bug numbers: 1234,9876
bugs=1463183,1463183
# Changelog:
# - Allow additional disk serial specification (rhbz#1463183).
# Add disk property 'shareable' (rhbz#1463183).
#
# Here is where you give an explanation of your update.
notes=Allow additional disk serial specification (rhbz#1463183).
# Enable request automation based on the stable/unstable karma thresholds
autokarma=True
stable_karma=3
unstable_karma=-3
# Automatically close bugs when this marked as stable
close_bugs=True
# Suggest that users restart after update
suggest_reboot=False

You can see that the changelog contains two entries. But the update suggest just one as a note and it does not suggest that the note could be multiline.

@vondruch I double check the code, this is the behavior fedpkg does now. I don't know the original background of this behavior. I do think it makes more sense to list all lines of changelog in notes.

I filed https://pagure.io/fedpkg/issue/125 for this issue.

I'm not saying all should go into notes, but if the "changelog" was copy&pasteable, it would be useful.

I see. You mentioned "not formatted appropriately", do you mean this

# - Allow additional disk serial specification (rhbz#1463183).
# Add disk property 'shareable' (rhbz#1463183).

and it is not good for copy&paste? What version of fedpkg and pyrpkg you are using? @vondruch

@vondruch Got it. Would you like to file an issue for the inappropriate format of changelog to see how we can improve it to make it more useful?

@lsedlar Can you review?

Looks good to me. Looking at Bodhi code, the template is always parsed with ConfigParser, so it should handle the indented multiline format fine.

No change, just rebased on latest master branch.

I'm still :thumbsup: on this.