fedpkg

#185 Do not check bodhi-client version
Closed by cqi. Opened by cqi.
cqi/fedpkg use-proper-version-of-bodhi  into  master

Download 185.patch

So far, EL6 is still needed to be considered for fedpkg, so
bodhi-client 1.x must be supported as well.

This patch does not check bodhi-client version to select proper version
of bodhi-client. Instead, if current system is EL6, version 1.x is
selected, otherwise bodhi command line will be constructed in the 2.x
format. This avoids fedpkg to be updated and released when each time a
new version of bodhi-client with increased major version is released.

Fixes #171

Signed-off-by: Chenxiong Qi cqi@redhat.com

rebased onto 2d7e34545398c55850e3e7736d0de593fd92e20c

I think this would work, but it seems more fragile than checking the version of actual executable. What if someone builds their own package with backported version of bodhi client? I don't think this is a common use case, but since we need to keep some check, why not check on the most specific value?.

Pull-Request has been closed by cqi

Make sense to me. Let's see how future bodhi releases impact the check in fedpkg.

(Comment was not added when close PR :)
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.