Fixes #187
A suggestion, maybe the size of response data can be reduced by only requesting fields version and short.
version
short
Looks good to me.
@cqi, good suggestion but the API doesn't seem to honor the fields keyword: https://pdc.fedoraproject.org/rest_api/v1/product-versions/?fields=short,version
fields
@mprahl, the documentation is not correct, it works like this: https://pdc.fedoraproject.org/rest_api/v1/product-versions/?fields=short&fields=version
rebased onto 7e24330dc39156d0d3d6146d73dca78be987af64
@lsedlar thanks! That worked.
Using urlencode seems incorrect, which returns active=True&fields=%5B%27short%27%2C+%27version%27%5D.
urlencode
active=True&fields=%5B%27short%27%2C+%27version%27%5D
Instead of encoding params manually, how about pass query_args to requests.get argument params?
query_args
requests.get
params
I changed it in the latest rebase but we should probably make this consistent in the rest of utils.py in a separate PR.
utils.py
rebased onto 00aed529cf22796fdae0d23f844221df640cc7c2
@cqi can you look again please?
Looks good to me. Thanks.
@cqi is this good to merge?
Pull-Request has been merged by cqi
Fixes #187