#205 Allow requesting modular repositories without bug ID
Merged by cqi. Opened by rdossant.
rdossant/fedpkg module-repo  into  master

Download 205.patch

Fixes #197

New modules won't require a formal review anymore.

Signed-off-by: Rafael Santos rdossant@redhat.com

Why add tests?

Please ignore this comment. Sorry.

        if bug and ns != 'tests':

This line in the _request_repo is also needed to be changed. So, when requesting a module repository, no need to query bug information from Bugzilla.

Test test_request_repo_module needs to be updated as well.

Please also update argument bug help message in register_request_repo with something like "Bug ID is not required for requesting a module repository.".

It would be good to rebase on master branch.

Thanks for your patch.

I'll send an updated version soon. Thank you for the review.

rebased onto e61ffd51b00f02e0a2147d694d942558a8f75185

PR has been updated. Let me know if there are any issues with it.

:thumbsup:

pretty please pagure-ci rebuild

@rdossant Can you fix the failure test?

Ignore this failure

======================================================================
FAIL: Test verify_sls with an SL that is not June 1st or December 1st. An
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/srv/jenkins/workspace/fedpkg/Builders/F26/test/test_utils.py", line 116, in test_verify_sls_invalid_date
    'December 1st'.format(eol))
AssertionError: 

it has been fixed in another pr.

It would be good to rebase it on master branch as well.

rebased onto a2589473000a7617f92d1cd052c8ea188cb30d96

Test fixed and patch rebased on top of master.

Commit c529e0a0 fixes this pull-request

Pull-Request has been merged by cqi

Pull-Request has been merged by cqi

Metadata