If the old placeholder is used, config parser will complain about bad value substitution.
I run into this: when using fedpkg from git checkout, it didn't work with old config using module placeholder, so I changed it to repo, but that broke old fedpkg. With this patch I can use the old config with both versions (and git version prints deprecations warnings). I'm pretty sure there will be some people with modified configuration and updating fedpkg will not cleanly update the config, and they will be confused by the error message.
If the old placeholder is used, config parser will complain about bad value substitution.
I run into this: when using fedpkg from git checkout, it didn't work with old config using
moduleplaceholder, so I changed it torepo, but that broke old fedpkg. With this patch I can use the old config with both versions (and git version prints deprecations warnings). I'm pretty sure there will be some people with modified configuration and updating fedpkg will not cleanly update the config, and they will be confused by the error message.