fedpkg

#264 Rewrite method to create bodhi update
Merged by cqi. Opened by cqi.
cqi/fedpkg fix-update  into  master

Download 264.patch

Executing command bodhi may have some problems. One major issue is it
does not return non-zero when fail to create update if something wrong
with the parameters within template.

Calling API directly will bring us full control of the creation workflow
to handle potential failures without relying on the behavior of command
bodhi.

In addition, this rewrite also validates some parameters before
creation.

Resolves: rhbz#1492480

Signed-off-by: Chenxiong Qi cqi@redhat.com

Fixes #158

rebased onto c545c9da37ceea0754ec3c62f4d406a6bbeacbd0

1 new commit added

  • Keep update template when fail to create

1 new commit added

  • Rewrite method to create bodhi update

Looks good to me. Do you know how stable is the API of bodhi client library?

OK for me as well.

@lsedlar I'm not sure I understand your question correctly. But, I think if there is anything changed in the API, whatever the interface or internal implementation, and that would break current fedpkg behavior, we have to update fedpkg implementation. This could be same issue to the CLI binary bodhi.

I was just curious if you know how often the library changes.

I was just curious if you know how often the library changes.

I don't know about that. :) After looking into several issues relative to command update, the benefit from calling API should be bigger than the potential effort of updating fedpkg when bodhi Python binding API changes.

Pull-Request has been merged by cqi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.