fesco

#1674 F26 System Wide Change: Enable TRIM pass down to encrypted disks
Closed Opened by jkurik.

Closed
Reopen Issue

For the FESCo team to discuss/approve on the next FESco meeting:

Override kernel default for dm-crypt mappings of LUKS1 encrypted volumes via flag put in /etc/crypttab file. This change should affect only newly created encrypted storage based on LUKS1 format during installation.

I'm +1 to this change.

Open questions on the list with no response. I'm curious how they're detecting whether something is an SSD or not.

poll /sys/block/*/queue/rotational ?

poll /sys/block/*/queue/rotational ?

Sure, that says whether it's spinning or not. But it doesn't account for things like USB sticks (which people do install on) and it blindly assumes anything that isn't rotational has working TRIM support. What happens on eMMC devices used on arm or otherwise?

There is no SSD detection, that pass down is always enabled. Change says "For rotational devices the cost of enabled discard is negligible". I don't actually understand the benefit because there's no change to enable fstrim.service by default; or a change to add discard mount option. So?
And I don't think either of those should be enabled by default for reasons I mention in:
https://bugzilla.redhat.com/show_bug.cgi?id=759920#c31

 
* AGREED: FESCo will defer this decision for a week due to ongoing
    discussion on the devel@ mailing list  (sgallagh, 16:59:50)

Adding Change owners on CC of this ticket: @vpodzime , @okozina
  • AGREED: System Wide Change: Enable TRIM pass down to encrypted disks is approved (+1:5,0:2,-1:0)

@jforbes changed the status to Closed
Metadata
None

meeting

None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.