#1945 Nonresponsive maintainer policy: stalled pull requests
Closed: Fixed Opened by churchyard.

Currently, our Policy for nonresponsive package maintainers says:

When a Fedora member notices that a maintainer isn't answering their bugs, not answering rebuild requests, emails or the like, these steps should be followed

I suggest to add src.fp.o Pull Requests explicitly in there:

When a Fedora member notices that a maintainer isn't answering their bugs, src.fedoraproject.org Pull Requests, not answering rebuild requests, emails or the like, these steps should be followed

Emphasis on added bits.

Rationale:

I file src.fp.o PRs a lot. In ~half of the cases, nobody responds. I'd like to have PRs explicitly stated in the policy so there are no doubts that the policy applies on PRs as well.


That makes sense to me. +1

+1

Can we advertise https://src.fedoraproject.org/user//requests better? Right now it's quite easy to miss pagure PRs, because once they original notification flies by, there's nothing to remind the user. I have a few open myself, which I wasn't aware of at all. One option would be simply put a notification in the header, "5 pull requests are waiting for your response." that'd link to https://src.fedoraproject.org/user//requests. This way anyone who visits src.fp.o would get notified, and hopefully we'll have a higher follow-through rate.

+1, but yes, we need this to be more visible. I don't know if a header would help out, how often do you go to the website if you aren't merging PR's already? Perhaps we could have some kind of weekly report to devel list showing user -> PR's ? Or a script that would emit a fedmsg about outstanding pr's per user and they could decide how they want to handle them (with a default of mailing them about it).

+1, but yes, we need this to be more visible. I don't know if a header would help out, how often do you go to the website if you aren't merging PR's already? Perhaps we could have some kind of weekly report to devel list showing user -> PR's ? Or a script that would emit a fedmsg about outstanding pr's per user and they could decide how they want to handle them (with a default of mailing them about it).

A weekly mailing to -owner@fedoraproject.org would probably be the right approach. I don't think people would complain about the noise; it's roughly the same as the NEEDSINFO reminders for Bugzilla. Bonus: it might help people remember when they own a package they stopped caring about and prompt them to orphan it so someone else can take over.

+1 to adding PRs to the list of reasons to consider someone non-responsive. I think notifications would be nice but not required (because people can always ping for PRs if they are urgent).

I'm +1, but probably for entirely different reasons than the rest of you.

Thus far the responses seem to have been under the assumption that people are used to a PR workflow, therefore it's obvious that people not responding to them means they're a non-responsive maintainer. In Fedora, I don't actually think this is the case. PRs have been around for a while, but it's still a net-new workflow for a lot of Fedora packagers. So yes, +1 lets add them to the policy, if only to keep reinforcing that it is supposed to be a new norm in Fedora workflow.

Metadata Update from @psabata:
- Issue tagged with: meeting

+1 to notifications and adding them to the policy

+1 to notifications and adding them to the policy

At the meeting today we agreed to update the policy to include the proposed addition.
I've updated the policy.

Furthermore, @kevin will work with @pingou to make PRs more visible. The solution might include Pagure sending out regular emails, to individuals or even lists.

Metadata Update from @psabata:
- Issue untagged with: meeting
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

Thank You!

Metadata