Issue #3402: Change: CMake drop non-standard variables - fesco

fesco

#3402 Change: CMake drop non-standard variables

Closed: Accepted May 27, 2025 by fale. Opened May 6, 2025 by amoloney.

Drop variables that are not standardized by CMake in the %cmake macro. The dropped options are-DINCLUDE_INSTALL_DIR, -DLIB_INSTALL_DIR, -DSYSCONF_INSTALL_DIR, -DSHARE_INSTALL_PREFIX and -DLIB_SUFFIX. Affected projects are tracked in this copr repo, please check if your packages are failing there.

Owners, do not implement this work until the FESCo vote has explicitly ended.
The Fedora Program Manager will create a tracking bug in Bugzilla for this Change, which is your indication to proceed. See the FESCo ticket policy and the Changes policy for more information.

REMINDER: This ticket is for FESCo members to vote on the proposal. Further discussion should happen in the Discourse discussion linked above. Additional discussion may happen on the Fedora Devel mailing list.

zbyszek commented May 6, 2025

Hmm, we're already going to have some pain from the CMake 4.0 upgrade. So maybe let's try not to catch two birds with one hand, and instead postpone this change until the upgrade to 4.0 is done? We're going to be short on people with CMake expertise anyway, so it'd be better to do this cleanup separately.

lecris commented May 6, 2025

My priority for the changes is CMake 4.0 -> Ninja -> this change. The deadline is also open-ended so wouldn't it be fine to push it back 1-2 releases if it slips?

It would be nice to have a decision on this, to reference for the PRs mostly.

fale commented May 6, 2025

Could it make sense to directly discuss this for F44?

ngompa commented May 6, 2025

Yeah, I think this Change is the one that results in the most pain all around. I'm also mindful that Fedora 44 is a GCC and LLVM update release, so people will be quite squeezed that cycle.

sgallagh commented May 6, 2025

Given the level of impact this is likely to have, I'd like to see us also make sure that this either lands before Fedora 45 Beta or else waits until Rawhide becomes Fedora 47. Fedora 45 will be the last full Fedora release before CentOS Stream 11 branches off when Fedora 46 splits from Rawhide. I'd like us to make sure we're not trying to clean up the mass-rebuild of this as part of the branching efforts for CS 11.

salimma commented May 6, 2025

Agreed that retargeting F45 makes sense (is this a record for the earliest CP ever proposed for a release?). That gives enough time before F46->CS11 if there is any slippage) and... yeah not landing this in a spring release would be really helpful in avoiding package managers getting burned out.

decathorpe commented May 13, 2025

Any objections to officially re-target this change at Fedora 45? The wiki page has not been updated yet, and the associated paperwork also still needs to be done.

ngompa commented May 13, 2025

I think Fedora 45 makes sense for this Change.

lecris commented May 15, 2025

I have updated it to F45. Worth pointing out that all of the affected packages by this are overlapping with either the CMake-4.0 or CMake-Ninja proposal, so they should be handled during those patches as well.

sgallagh commented May 20, 2025

OK, since there has been quite a bit of discussion so far, I'm going to say that we re-set the clock on voting with this proposal:

"This Change is approved for inclusion into Fedora 45".

+1 from me.

decathorpe commented May 20, 2025