#1450 Accounts with only bodhi activity(bots) are marked as inactive packagers.
Opened by humaton. Modified

If for whatever reason datagreper fails to return a value this will catch the exception and return false.

So if datagreper returns 500 because of an infra glitch it will mark the account as inactive.


Hmm I have missed the https://pagure.io/fedora-infrastructure/issue/11271#comment-854459 about the emitted messages.

But I still think the try/catch should not catch all exceptions, the return value of check_bodhi_activity should not be false if there is an infra issue.

session.get() will retry 5 times before raising the exception. And even if we mistakenly consider a user as inactive, they will be notified (hopefully) and they can reply to our ticket. If we had to consider the user as active when datagrepper query fails, there's a chance that we don't catch all inactive users.

The real problem is that "hopefully" I added before... see https://pagure.io/find-inactive-packagers/issue/1449

Metadata