This is the big TODO.

Maybe this should be --kde5? Maybe it should be--runtime=flatpak-kde5-runtime ? Maybe it's not necessary at all and the user should just edit the result? (Different from the fedmod case, since fedmod needed to know the runtime). I'd probably skip the -K shortcut in any case, since it's not like this will be typed all the time.

I'm thinking this gets wrapped by fedpkg as flatpak-init, to go along with flatpak-build flatpak-build-local flatpak-build-rpms flatpak-build-rpms-local So maybe just 'flatpak-module init' ?

This variable should be 'runtime_version'. I think we initialize it by current Fedora stable release. Adam Williamson's recommendation was to use bodhi for that. Something like:

response = requests.get("https://bodhi.fedoraproject.org/releases/?state=current")
response.raise_for_status()
return max(int(
    r["version"])
          for r in response.json()["releases"]
          if r["id_prefix"] == "FEDORA-FLATPAK"
))

(Call fromrun() not __init__()). I don't know if this needs to be overridable, other than by editing, but the command ends up with a --runtime argument, it could have a --runtime-version argument too.

Generally looks fine to me, other than the naming / cli questions above.

Second draft posted.

ping @otaylor

A bit stray in this patch, if an end-user hits this, they are still going to be puzzled :-) ... but sure.

A bit stray in this patch, if an end-user hits this, they are still going to be puzzled :-) ... but sure.

Sorry, had that locally, but it was meant for a separate PR. Do you want me to drop that here?

This generally looks great. The style of the tests is clearly not the same as the other tests, but that is fine since they are moving from fedmod - if we want to make things consistent later, we can do that. The only request I would make here is to move things from tests/files/flatpak to tests/files/generator - since everything is flatpak in flatpak-module-tools.

Yes this were taken straight from fedmod, with the modulemd stripped out and adjusted the integration to the rest of the package, but didn't consider code style.