#1687 flake8 failures on master
Closed: Fixed by mikem. Opened by mikem.

When I run the unit tests, I see several items flagged by flake8

./module_build_service/web/mse.py:498:31: F522 '...'.format(...) has unused named argument(s): stream
./module_build_service/common/config.py:874:43: E741 ambiguous variable name 'l'
./module_build_service/common/config.py:878:32: E741 ambiguous variable name 'l'
./module_build_service/builder/MockModuleBuilder.py:231:17: E741 ambiguous variable name 'l'
./module_build_service/scheduler/reuse.py:441:19: F523 '...'.format(...) has unused arguments at position(s): 0
ERROR: InvocationError for command /usr/bin/flake8 --exclude=.tox,.git,module_build_service/migrations,build,.env,tests/integration (exited with code 1)

The mse.py one was recently introduced, but other items go way back. I'm not sure if we were just ignoring these before or if something has changed in our flake8 config, but we should definitely get back to clean flake8 output.


Commit 7084556a fixes this issue

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/mbs/issues/1687

Please continue any further discussion there.

Metadata
Related Pull Requests