#185 [RFE] When building modules, set %{_module_build} macro
Closed: Fixed Opened by sgallagh.

We are currently working up a set of packaging guidelines for Fedora to allow us to skip certain parts of the build process (such as not running tests or using pre-generated documentation). As part of this, we will need to have a special macro set inside module builds to indicate to rpmbuild that it should skip these pieces.

We are currently expecting that we will use the macro %{_module_build} and will want it set to 1.


Patch in #187.

Commit 83bc4eb0 fixes this issue

@ralph changed the status to Closed

We are currently working up a set of packaging guidelines for Fedora to allow
us to skip certain parts of the build process (such as not running tests or
using pre-generated documentation).

I bet this is not related to modules, but rather to general "packaging
guidelines", right? Do we have a links to the proposals?

As part of this, we will need to have a special macro set inside module builds
to indicate to rpmbuild that it should skip these pieces.

We are currently expecting that we will use the macro %{_module_build} and
will want it set to 1.

This binary %_module_build (0 or 1) concept is buggy, unfortunately.

In most cases -- the fact we build package for module neither means that we
want to avoid building documentation, nor we want to avoid running the
build-time testsuite, nor we want to disable some feature.

So it rather looks like we want to misuse %_module_build macro for
"bootstrapping" issues; e.g. bugzilla request:
https://bugzilla.redhat.com/show_bug.cgi?id=1444865
While the correct solution is to somehow provide the missing (build) requirements.

This or that way, @ppisar's proposal sounds much better:
https://pagure.io/modulemd/issue/34
That would mean that package mainainers just prepare "knobs" to be
reused by module yaml specification.

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/mbs/issues/185

Please continue any further discussion there.

Metadata