#1 Update the spec file templates
Merged by tagoh. Opened by pnemade.
Unknown source master

Download 1.patch

Here I have tried to update the fonts spec file templates according to current packaging guidelines.

I guess it's good to have metadata of appstream there too?

1 new commit added

  • Update specfile template for adding AppStream metainfo files as per https://fedoraproject.org/wiki/Packaging:AppData

I have tried to add appstream files support here. Please review this PR :)

maybe nice to keep consistency with the following example. I meant %{fontname}-%{FAMILYX}.metainfo.xml instead and add a comment here to have for all of fonts. also nice to update for fontconfig one as well?

8 new commits added

  • Update specfile template for adding AppStream metainfo files as per https://fedoraproject.org/wiki/Packaging:AppData
  • Change %setup to %autosetup as per https://fedoraproject.org/wiki/Packaging:Guidelines#.25autosetup
  • Use %license tag for adding the license file
  • defattr is no longer necessary to explicitly included in spec files
  • In the past (pre rpm 4.4), it was necessary to have a %defattr section at the beginning of each %files section, but this is now the default and no longer necessary to explicitly include
  • The %clean section is not required now. See https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
  • buildroot will automatically be cleaned before commands in %install called. https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
  • Group tag is optional now See https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag

Updated this PR

trivial things though, missing - stuff here.

maybe %{fontname}-.metainfo.xml? because we have the metadata per sub-packages?

8 new commits added

  • Update specfile template for adding AppStream metainfo files as per https://fedoraproject.org/wiki/Packaging:AppData
  • Change %setup to %autosetup as per https://fedoraproject.org/wiki/Packaging:Guidelines#.25autosetup
  • Use %license tag for adding the license file
  • defattr is no longer necessary to explicitly included in spec files
  • In the past (pre rpm 4.4), it was necessary to have a %defattr section at the beginning of each %files section, but this is now the default and no longer necessary to explicitly include
  • The %clean section is not required now. See https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
  • buildroot will automatically be cleaned before commands in %install called. https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
  • Group tag is optional now See https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag

missing - here?

8 new commits added

  • Update specfile template for adding AppStream metainfo files as per https://fedoraproject.org/wiki/Packaging:AppData
  • Change %setup to %autosetup as per https://fedoraproject.org/wiki/Packaging:Guidelines#.25autosetup
  • Use %license tag for adding the license file
  • defattr is no longer necessary to explicitly included in spec files
  • In the past (pre rpm 4.4), it was necessary to have a %defattr section at the beginning of each %files section, but this is now the default and no longer necessary to explicitly include
  • The %clean section is not required now. See https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
  • buildroot will automatically be cleaned before commands in %install called. https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
  • Group tag is optional now See https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag

Updated Please check. Hopefully I have not missed anything now :)

Everything looks good to me now :)

Pull-Request has been merged by tagoh

Metadata