From 1c30361f6dfa364f9a686c7b7034cf1bd3d6f82e Mon Sep 17 00:00:00 2001 From: Jan Kaluza Date: Apr 23 2018 17:34:08 +0000 Subject: Pass dry_run and manual options in ErrataRpmsSignedHandler. --- diff --git a/freshmaker/handlers/errata/errata_advisory_state_changed.py b/freshmaker/handlers/errata/errata_advisory_state_changed.py index 83ee84f..3fd83ea 100644 --- a/freshmaker/handlers/errata/errata_advisory_state_changed.py +++ b/freshmaker/handlers/errata/errata_advisory_state_changed.py @@ -101,9 +101,11 @@ class ErrataAdvisoryStateChangedHandler(BaseHandler): "advisory %d, because its state changed to %s.", errata_id, event.advisory.state) advisory = advisories[0] - db_event = ErrataAdvisoryRPMsSignedEvent( + new_event = ErrataAdvisoryRPMsSignedEvent( event.msg_id + "." + str(advisory.name), advisory) - return [db_event] + new_event.dry_run = event.dry_run + new_event.manual = event.manual + return [new_event] def handle(self, event): errata_id = event.advisory.errata_id diff --git a/tests/test_errata_advisory_state_changed.py b/tests/test_errata_advisory_state_changed.py index 6a7c11b..79c5740 100644 --- a/tests/test_errata_advisory_state_changed.py +++ b/tests/test_errata_advisory_state_changed.py @@ -658,10 +658,13 @@ class TestErrataAdvisoryStateChangedHandler(helpers.ModelsTestCase): ev = ErrataAdvisoryStateChangedEvent( "msg123", ErrataAdvisory(123, 'RHSA-2017', state, ['rpm'])) ev.manual = manual + ev.dry_run = manual # use also manual just for the sake of test. ret = handler.handle(ev) if db_event_state == EventState.FAILED or ev.manual: self.assertEqual(len(ret), 1) + self.assertEqual(ret[0].manual, manual) + self.assertEqual(ret[0].dry_run, manual) else: self.assertEqual(len(ret), 0)