From 6dc5416dd0fcd477067d29fda73732c841750b7b Mon Sep 17 00:00:00 2001 From: Jan Kaluza Date: Apr 11 2019 05:45:01 +0000 Subject: Fix `HTTPError.response` comparison. The `requests.Response` evaluates to `True` if it is `HTTP 200 OK`, otherwise it is `False`. The code changes by this commit however wanted to check if `e.response` is None or set to some Response. This did not work, because even if `e.response` was set, it evaluated to `False`, because its status code was `401`. --- diff --git a/freshmaker/errata.py b/freshmaker/errata.py index bf7701f..58f5560 100644 --- a/freshmaker/errata.py +++ b/freshmaker/errata.py @@ -132,7 +132,7 @@ class Errata(object): **kwargs) r.raise_for_status() except requests.exceptions.RequestException as e: - if e.response and e.response.status_code == 401: + if e.response is not None and e.response.status_code == 401: log.info("CCache file probably expired, removing it.") os.unlink(conf.krb_auth_ccache_file) raise