PR#407: Fix the switched `depending_events` and `depends_on_events` lists. -

freshmaker

#407 Fix the switched `depending_events` and `depends_on_events` lists.

Merged Jul 19, 2019 by jkaluza. Opened Jul 18, 2019 by jkaluza.

jkaluza/freshmaker depends into master

jkaluza commented Jul 18, 2019

It seems to me that those REST API fields are switched. If Event A
depends on B, the B is listed in A's depending_events, but it
should be listed in the depends_on_events.

This commit fixes this, adds more comments to the code and also
renames depends_on_events to depending_events.

jkaluza commented Jul 18, 2019

@giulia, can you check this please? I found this when testing that KR we are working on.

gnaponie commented Jul 18, 2019

Oh man :( Sorry about that. Yeah, looks good!

Pull-Request has been merged by jkaluza

Jul 19, 2019

Metadata

Assignee

None

Tags

No Tags

freshmaker

#407 Fix the switched `depending_events` and `depends_on_events` lists. Merged Jul 19, 2019 by jkaluza. Opened Jul 18, 2019 by jkaluza. jkaluza/freshmaker depends into master

Metadata

#407 Fix the switched `depending_events` and `depends_on_events` lists.

Merged Jul 19, 2019 by jkaluza. Opened Jul 18, 2019 by jkaluza.

jkaluza/freshmaker depends into master