#85 Log error when no parent image is found
Merged by jkaluza. Opened by cqi.
cqi/freshmaker log-error  into  master

Download 85.patch

Fix #82

Signed-off-by: Chenxiong Qi cqi@redhat.com

Hmm, shouldn't this be logged only when parent is not found?

rebased onto 15c8429a73ed69bdbdf6e96fe9775c38c9402b8e

Hi @sochotni fixed my mistake. Thanks.

Should this be reason to fail the rebuild completely?

Any response on @jkaluza's question? I'm afraid I don't know.

If someone knows - cool. Please comment.

If we don't know, that's ok. I'm then I'm :+1: to merging "just logging" and seeing how it goes. We can add a hard escape later if we're unsure.

Yeah, sorry - I think it might be safer to actually error out. Because otherwise we risk that we will miss something - error-ed out build will be visible.

That said I'd be OK merging this and then tweaking separately

OK, let's merge this one. There are multiple places where we log.error, but should stop the rebuild instead. Maybe just fix them all in once.

Pull-Request has been merged by jkaluza

Metadata