This looks okay from a read through, but it's a little hard to review without more context about why make this change. Can you add more context to the description, comment, or (preferably) commit message(s) next time?
Also, jenkins is mad. Is that known/expected?
Add unique constraint on (event_id, event_dependency_id)?
(event_id, event_dependency_id)
So, the reason why we need this is situation where we have two advisories touching the same container image. For example nss and openjdk advisory.
When "nss" advisory comes in, Freshmaker rebuilds all container images containing "nss". Later, when "openjdk" advisory comes in, Freshmaker has to rebuild all the container images containing "openjdk", but it also has to include "nss" in the build if those images also contain "nss". Otherwise this rebuild would not ship the updated "nss".
Freshmaker therefore has to track that "openjdk" rebuild depends on "nss" rebuild. It needs it to find out the ODCS compose_id for "nss" advisory to include it in yum_reposurl when submiting builds to Koji.
And this is what this PR does.
rebased onto 32204539da34ea124763f794d2952fb5b12bfa12
Jenkins needed restart, it works now.
rebased onto 8fcc800af052b7fceb342f1d40c5bb71c9da83fb
Rebased to latest master.
rebased onto 47544e918e5be7f3bf4f05ac9e1eb0d83c2e2ab2
This commit seems not necessary, as both self._find_and_record_images_to_rebuild and self._prepare_yum_repo commit changes.
commit
self._find_and_record_images_to_rebuild
self._prepare_yum_repo
Pull-Request has been merged by jkaluza