That looks good to me (I assume you checked it builds and works). That's how I would have done it.

@qulogic up to you now

I assume you checked it builds and works

I haven't. But I assume it would work.

Tested and it doesn't work.

It seems the "other files" are not included by default but need to be specified with --include-extension.
I don't understand the point of the switch case with .proto, .md and so on thoughk

Ok, weird that @jchaloup gone to all this pain for something that does not work

Reading the urfave/cli documentation (that I don’t know well, I used jawher/mow.cli in modist), it seems you need to define a default extension value

cli.NewStringSlice(".s", ".proto")

(https://github.com/urfave/cli/pull/392)

and then set it as value

Value: cli.NewStringSlice(".s", ".proto")

here https://pagure.io/golist/blob/master/f/cmd/golist/golist.go#_80

But, I may be misreading the documentation, and I have no access to by coding setup right now :( It needs testing

Used:

            Value: &cli.StringSlice{".proto", ".md", ".s"},

We're still using the v1 of urfave/cli. v2 never caught up and the whole project seems abandoned since 2016.

Tested in COPR and it works: https://copr.fedorainfracloud.org/coprs/eclipseo/golang-ng/build/935905/

LGTM.