golist

#30 Don't skip testdata
Merged by eclipseo. Opened by krouma.
Unknown source master

Download 30.patch

Testdata can be used by other packages, e.g. github.com/go-git/go-git uses testdata of golang.org/x/crypto/ssh, but they are not provided by golang-x-crypto-devel, so building go-git (generated by go2rpm) fails because of failed dependency.
Also testdata are generally useful while developing and resulting binaries will not contain them anyway.

Hmmm, in general I add them manually but ok.

Pull-Request has been merged by eclipseo

Sorry, I've had to revert this change. After applying it, it causes several bugs:

  1. testdata that includes invalid Go code can cause golist to panic, as it does so when importing a directory fails.
  2. Imports in testdata now get added as dependencies, which can break %go_generate_buildrequires, if these are non-existent.
  3. %gocheck attempts to run tests on testdata code, but that's not how Go does it. These files may be invalid as well, causing %check to fail.
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.