greenwave

#268 It's not possible to reconstruct correct ResultsDB link from decision change message
Closed: Rejected Opened by lholecek.

Closed: Rejected
Reopen Issue

For example, message [1] contains:

"subject": [
      {
        "productmd.compose.id": "Fedora-Cloud-Base-Vagrant-Rawhide-20180726.n.2.x86_64.vagrant-libvirt.box"
      }
    ]

The query to get results is constructed from the subject [2], but there can be multiple queries to ResultsDB, and in this case productmd.compose.id=... in the query is wrong (it needs item instead and type=compose).

[1] https://apps.fedoraproject.org/datagrepper/id?id=2018-3f0f22f8-6f94-4d8a-95c6-399ffdcf1ada&is_raw=true&size=extra-large

[2] https://github.com/fedora-infra/fedmsg_meta_fedora_infrastructure/blob/444ccfa6eaaa1541081d8a3c48b48a229595f153/fedmsg_meta_fedora_infrastructure/greenwave.py#L45

What do you recommend? Should the greenwave message supply a list of resultsdb queries (urls) in the message?

FWIW, maybe it is too complicated to expect a nice url to get all the results for a particular decision and instead we should just remove the implementation for link() in fedmsg.meta there.

Could we just link to the actual decision itself, in the Greenwave API?

Sure, it will be a blob of JSON which is not very pretty for a human. But nowadays Firefox has a nice JSON browser.

And sure, the decision may have changed again since the message went out... but at least it is something?

Sorry, ignore that suggestion... I just remembered that the decision usually has to be POST'ed not GET. So that won't work most of the time.

Clearly, I have already been away from Factory 2.0 work for too long. :-P

Closing since we don't need this now (I'm not even sure for what is this used).

Metadata Update from @lholecek:
- Issue close_status updated to: Rejected
- Issue status updated to: Closed (was: Open)
Metadata
None

bug

None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.