#374 Greenwave emits odd compose decision fedmsgs when Autocloud tests happen (I think)
Closed: Invalid by adamwill. Opened by adamwill.

So, good news - Greenwave is emitting decision fedmsgs again!

Kinda bad news - it's emitting some pretty odd ones. Like the one I just showed @ralph.

It's a compose decision, but it seems not to have an actual subject. There's a subject type, but no...subject. This is reflected in the way the fedmsg2meta-generated text description of the result is "greenwave says NO-GO on "something" for "rawhide_compose_sync_to_mirrors"" - note the "something" there.

Given that the only satisfied requirement is "compose.cloud.all" - which is the ResultsDB 'testcase' that autocloudreporter uses when forwarding Autocloud results to ResultsDB - I suspect these decisions are being generated in response to those autocloud tests.

I don't remember all the ins and outs of how greenwave decides to emit decision fedmsgs and when, I'll have to look into it again. But there's obviously something a bit off with these decisions.

Emitting weird 'no go' decisions isn't really a huge problem, of course, because they'll probably just kinda get...ignored. But it's probably worth looking into. We'll have to wait for a finished compose and the openQA tests to run to see whether we get a valid decision at the end of all the openQA tests...


Oh, actually, I guess I'm just reading it wrong: the subject_identifier is in the requirements now, not the top level of the message dict.

So I suspect the "something" means we need to update the fedmsg2meta code for greenwave, which is probably looking for the subject in the wrong place...

Ah, no, there is a subject, it's just hidden in the middle of the JSON dump. Alright. This is a fedmsg-meta bug. Please close it.

Metadata Update from @adamwill:
- Issue close_status updated to: Invalid
- Issue status updated to: Closed (was: Open)

Turns out the latest version of fedmsg-meta was still stuck in updates-testing...I pushed it stable, I assume that means it'll find its way into production in infra.

Metadata