greenwave

#315 Check decision_context and others in gating.yaml files
Merged by gnaponie. Opened by lholecek.
lholecek/greenwave remote-decision-context  into  master

Download 315.patch

Use policies from remote gating.yaml files only if they match
decision_context, product_version and subject_type for current
decision (as it's done for internal policies).

Fixes #282

Signed-off-by: Lukas Holecek hluk@email.cz

+1
But we should also update the doc. In the "Tutorial - How to configure the RemoteRule" there is written that it's not really important how you configure the decision context.

But we should also update the doc. In the "Tutorial - How to configure the RemoteRule" there is written that it's not really important how you configure the decision context.

Oh, forgot about that. Updating...

rebased onto 8ac429c690c714bd81d16f8fd2efcb732315a0ea

I've removed following line from docs.

the decision_context it is not really important at the very moment.

It already mentions that the context must match the one in decision request. But it also mentions that product_version and subject_type must match. Should I check for all of these values instead of just the decision_context? I would need to refactor the code bit more.

Yeah so I guess we should make the code consistent with the doc

rebased onto 24ce15982c74c69ffaa1da124b19a9fdd992fa9e

rebased onto 8384b6f5887b8c9b5e88e650fba004b25580482b

Fixed.

rebased onto 34318fb350509ca60f69f07bce3ecf158e77cdde

rebased onto 373a5837f61b4b42a02ee63b641746ae65dbcd8d

+1

Commit a3663243 fixes this pull-request

Pull-Request has been merged by gnaponie

Pull-Request has been merged by gnaponie
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.