#511 Use extra->source instead of just source.
Merged by vmaljulin. Opened by vmaljulin.
vmaljulin/greenwave FACTORY-4898  into  master

Download 511.patch

This fixes #470.

Signed-off-by: Valerij Maljulin vmaljuli@redhat.com

It should not be logged as an error since it's expected to work this way for containers.

Can we have a test for some container data missing the extra.source field?

Can we have a test for some container data missing the extra.source field?

It doesn't matter if it is container data or everything else. If it has no extra.source it will check the source as it was before (and this behavior is tested) regardless of other circumstances.

rebased onto 4dab05039fb4152b2f159d75644b0776fb75527e

It should not be logged as an error since it's expected to work this way for containers.

changed to warning

Even warning may be too obtrusive in logs. I don't want to see the message being printed for every container build since it's expected.

It might be better for now to just use extra.source for RPM builds and source for container builds -- they have not yet decided to support the new field for containers: https://github.com/containerbuildsystem/atomic-reactor/issues/1248

The right field is build['extra']['source']['original_url']
You can check a real build example here:
http://pastebin.test.redhat.com/811863

I wouldn't log it at all. It's not something we care about.

rebased onto ad9c67541a606beab64c0f3240ea8a23e6b9409c

rebased onto 1923eb5da4d622031cb2c14aa5f2adfb0cf5ba57

Pull-Request has been merged by vmaljulin

Metadata