From 7bd3c9f40a80bc535e20cd983092b588d2a8ffb0 Mon Sep 17 00:00:00 2001 From: Robbie Harwood Date: May 01 2019 15:27:13 +0000 Subject: Avoid uninitialized free when allocating buffers Signed-off-by: Robbie Harwood --- diff --git a/src/gp_export.c b/src/gp_export.c index dbfddeb..a5681c0 100644 --- a/src/gp_export.c +++ b/src/gp_export.c @@ -300,6 +300,7 @@ static int gp_encrypt_buffer(krb5_context context, krb5_keyblock *key, &data_in, &enc_handle); if (ret) { + free(enc_handle.ciphertext.data); ret = EINVAL; goto done; } @@ -308,12 +309,12 @@ static int gp_encrypt_buffer(krb5_context context, krb5_keyblock *key, enc_handle.ciphertext.data, out); if (ret) { + free(enc_handle.ciphertext.data); goto done; } done: free(padded); - free(enc_handle.ciphertext.data); return ret; }