#284 Add an SOP for cloud-image-uploader
Merged by kevin. Opened by jcline.
jcline/infra-docs-fpo cloud-image-uploader  into  master

Download 284.patch

This is just the basics for now. In addition to adding AWS and GCP
sections (once the image uploader supports those clouds), I plan on
adding details on common tasks (deploy a new version, deal with
failures, etc).

Looks like a good start to me.

A few things I wonder about:

  • Do we need to prune images ever? would this be something to add to this app? Or something seperate?

  • We probably should sometime have a larger conversation on if we want to add a QE step in here. ie, do we want to test and only upload passing images? or do we want to upload everything, but somehow 'tag' images that pass? But I am not sure at all how people search for images on Azure...

But I'm fine merging this as is and expanding on it/discussing those things somewhere else.

Looks like a good start to me.

A few things I wonder about:

  • Do we need to prune images ever? would this be something to add to this app? Or something seperate?

Yes, that's next on my to-do list and I've got a few ideas, but nothing I've quite committed to just yet so I didn't document anything. I'm currently leaning towards having a Function run in Azure that just runs once a day/week/whatever and implements the pruning rules. We can write it as a Python function and maybe even ensure it exists via Ansible, or just set it up one-time manually if that's not easy/possible.

  • We probably should sometime have a larger conversation on if we want to add a QE step in here. ie, do we want to test and only upload passing images? or do we want to upload everything, but somehow 'tag' images that pass? But I am not sure at all how people search for images on Azure...

Indeed. The way it currently works is all the images are marked with a flag to "exclude them from latest" so the only way to use them is to explicitly boot the image ID, which we don't link to. You can then flip that flag to expose them as the latest (assuming they sort higher, semver-wise, I think). For the super short term I'm going to handle promoting them manually, but I'm definitely motivated to automated that process.

rebased onto fe02817e0edfc26db8cbcaa8035f6e0e8283aa4b

The service now cleans up Azure images, so I've documented that in the SOP.

rebased onto fe02817e0edfc26db8cbcaa8035f6e0e8283aa4b

rebased onto 475e4023ad5b734e5090112cb01945f249d32663

Lets get this merged.

Pull-Request has been merged by kevin

Metadata