#403 Ignore local build preview.pid
Merged by kevin. Opened by mwinters.
mwinters/infra-docs-fpo nopreview  into  master

Download 403.patch

This file gets rebuilt every time we run ./docsbuilder.sh -p and is not useful outside of one's local system.

Signed-off-by: Michael Winters fedora@mwinters.net

Intentionally extremely simple PR. My first! More of a smoke test than anything, to make sure I'm doing this right.

rebased onto 0ad40057fb42dc355420d812ebc597cb96d06ffc

Can you add a bit of info in the commit about why we want to ignore this? ;)

Otherwise it looks completely reasonable to me.

Can you add a bit of info in the commit about why we want to ignore this? ;)

Otherwise it looks completely reasonable to me.

Noob questions:

  1. Is editing the first comment in the PR sufficient? If so, done.
  2. If not, can I amend the commit and force-push to my fork to keep the git history clean?

Yeah, if it's just a comment change you can do:

git rebase -i HEAD

and edit the comment, then do 'git push --force' to push the change to your fork (the pr will automatically update).

If you want to squash commits, what I do is:

make the new commit
git rebase -i HEAD~2 (or however many commits)
tell it to squash the second and later ones, update the comment
git push --force

rebased onto 0ad40057fb42dc355420d812ebc597cb96d06ffc

rebased onto 0ad40057fb42dc355420d812ebc597cb96d06ffc

Cool. Thanks!

Pull-Request has been merged by kevin

Metadata