Needless redirects could still be removed

For most 'advanced' ciphers mcrypt + bcrypt are needed (not included in the default LIves OR kickstarts)

Appending to the end here, after the 'or', makes it read as if USB drives are an example of a network location. How about ~"an ISO image.... on either optical or USB disk?"

This is just an example, it seems gratuitous to change it.

This reads to me as if the inst.gpt option is commonly marked as UEFI+CSM or LEGACY. Can you restructure this?

This is good info to add here, but the grammar could be more clear. Can you please restructure this sentence?

This option has a different default behavior depending on the available memory, and we're describing the behavior and how to change it in each circumstance equally. I don't think removing the clause for disabling the default where <2GB of memory is available adds value here.

We're linking to the docs for kdump in both kickstart and GUI processes, we should stick to describing kdump's function and parameters there.

oops :)

GRUB gives you the option of both a function key and ctl+x to boot; in my experience, ctl+x works universally but the function key does not on some systems. ctl+x also aligns with the downstream RHEL Installation Guide.

A good addition, but a few thoughts on presentation:

• We shouldn't capitalize for emphasis. If the concept is important enough to call special attention to it,
  an admonition would be more appropriate, ie , , or . If the idea does not warrant
  an admonition, we probably don't need to emphasize it more than an tag around a phrase.
• 'disk layout' and 'disk size' doesn't need to be pluralized, you could more succinctly say 'disk layout and size'.
• s/awkile/awhile/

I wouldn't qualify an "Are you sure you want swap?" type message with blocking filesystem layout error messages, to the point that I actually had to reread this several times to get what you were communicating. This should be rephrased to be more clear, or maybe even just left as is.

Good addition! DocBook also has a tag you can use to wrap a set of tags, but it isn't imperative.

I actually prefer the brevity you've added to this sentence, but I don't think we should make this change for a different reason. The change is minor and doesn't affect what the sentence communicates, but the act of changing it will require all translations of the sentence be performed again. It adds a deceptively large amount of work for such a small change.

brevity vs l10n team effort concerns apply here too.

I don't see thinp as 'experimental' at this point. Is there a reference we can cite here?

This is a good point to add, but I think we can be more positive in delivery. It would be best to have an article, list discussion, or document to point to , ie "For information on the features and limitations of btrfs, refer to..." and implicitly recommend that the reader make a decision for themselves.

Because we're working with XML, the '<' character should be represented with it's entity, &lt'. There's a list of such things and more info at http://www.docbook.org/tdg/en/html/ch01.html#s-entities .

hmm... this could be made more succinct if you clarified in the first sentence that XFS cannot be shrunk, only grown.

how about ..."or if you use a debug kernel, as debug symbols" ? It might be nice to give a rough estimate too, do you know how much space is consumed with the default (installonly_limit) number of debug kernels installed?

Now that you bring attention to it, I think the technology has progressed to the point that we can defer with this recommendation. Since changing this would require retranslation, I think it would be better to research the validity of the recommendation before changing the copy.

Good catch! We could save some reading time by mentioning /boot/efi with /boot, instead of adding a new paragraph.

That is in fact the only time it is used, for a proper UEFI system gpt is already in place.

I'm wary of describing the default value here; If you use the installer you'll discover the info on your own, and if we cite that here we'll have to verify the citation for every release.

s/luie/lieu/ , and there's an open parenthesis without it's close.

So link only to the kdump section, and drop the ks link, with a bit more 'why would I use / need to use this' ?

So a 'nothing to see here, move along' ?

Never seen or used the Ctl+X myself but sure, not sure the RHEL part should really dictate our docs that much tho tbh.

The object of your sentence is not clear, it needs to be stated differently.

No, don't make changes to this line at all. This is only a list of kickstart options, and kickstart itself is documented elsewhere.

Remove '' . I'm assuming it's an accident.

It seems to read better with the brevity, hence I question if the l10n hit might be worth it on this one.

I agree that it reads better, but no, it isn't worth it. You're asking at least one and probably two people from each of dozens of language teams to review and and translate the string, there isn't enough value in the added brevity to justify that.

Typo here, please revert.

Good point about wifi! I think there's a Workstation netinstall now; if there's wifi support in that, we should instead use a admonition to warn that only the Server image does not have wifi, and rephrase this general description of the netistall to be flavor-agnostic.

Good point about wifi! I think there's a Workstation netinstall now; if there's wifi support in that, we should instead use a admonition to warn that only the Server image does not have wifi, and rephrase this general description of the netistall to be flavor-agnostic.

This section describes interacting with a tmux window, your edits to the keycombos are incorrect and should be reverted.

This entire statement seems incorrect - doesn't the installer ask you about language and layout before anything else, continue the installation using those settings, and install a system with the same settings?

This file isn't actually published to the site, it's used by anaconda for inline help. We keep it in this repo because other content overlaps, and anacondas help files are generated from the installation guide. In that context, it doesn't make sense to make this change, please revert.

Is this only a rephrasing, or does the Manual/Automatic dialog element no longer exist?

Is this only a rephrasing, or does the Manual/Automatic dialog element no longer exist?

This is mostly a general observation that memory constraints have a performance impact, I don't think we need to make that observation here.

We don't need to point out that the UI element that is highlighted when the dialog opens will be the option chosen unless specified otherwise.

This change doesn't merit retranslation, please revert.

This is just whitespace added to the end of the line, I think. Not a big problem or a blocker to a merge, but as a practice you should be careful about leaking superfluous changes into your commits.

/usr/bin/pykickstartexists, and is written in python3. Please revert this change.

This set of changes serves no purpose, please revert.

The pykickstart package provides /usr/bin/ksvalidator, python3-kickstart is strictly python modules. Please revert.

This is a duplicate pair of lines, please revert.

We have an entire section describing partition layout, I don't think this paragraph needs to get into it. I'm also not confident that autopart creates a /boot by default - can you verify this?

inst.commandline and inst.text are still interactive methods; if the prompt is not presented to the user, that is a bug. Have you verified this behavior? I do like an admonition to remind readers that a passphrase declaration is required for an unattended install, though.

We could more succinctly discuss the backup passphrase with the regular passphrase, and there are some xml validity issues here that would also go away if both were in the same admonition.

Do you have a technical justification for removing the aes-cbc-essiv:sha256 recommendation?

I still see the code for this option in anaconda, do you have a technical reference for removing this list entry?

this breaks xml validity, please revert.

revert removing lines 204-213 please.

revert removing lines 162-195 please.

We already said that here.

Is there a technical justification for removing the aes-cbc-essiv:sha256 recommendation? Did you intend to describe requirements and reasons to use ciphers that are not supported by the installation image here?

This breaks XML and logical document structure by removing the variable part of a varlistentry, please revert.

This is good info to add, but your change could be rephrased to be more clear and remove spelling errors.

This is more of a rephrasing for personal preference than an improvement; while this usage of 'an' has fallen out of favor in American English, it is still valid, Please revert.

typo, please revert.

We're losing some of the copy's utility here; you've removed the part that explains to the reader how to make the --autoscreenshot option useful. Unless there's a technical change to the option, please revert.

this admonition is still valid, please revert.

This info is valid and appropriate, please revert it's removal.

This breaks XML; if the kickstart option is no longer valid, you should only remove the block. If it is deprecated, can you please cite a reference? It's usually best to make such references in a commit message.

This info is valid, please revert it's removal.

The information is accurate and inappropriate; I don't know what you mean by 'redirect' in this context, or why you are removing these lines.

...appropriate. It is not inappropriate information.

s390 Fedora does exist, please revert.

Can you provide a reference showing the kexec option has been removed from anaconda?

Anaconda plugins are a real thing, please revert removing this section.

This is an unnecessary change, please revert.

This is an unnecessary change, please revert.

I'm going to defer to Petr on removing or using this warning; this change is a good example of why smaller pull requests are better.
Also, you removed a that was not part of your intended change.

This would be better as a or ; it will get formatted more appropriately that way.

Thanks for the review, Corey! I've reviewed your edits and made some comments in Pagure. However, I think this is too many changes to effectively handle in a single pull request. I'd like to move forward with a slightly different workflow for you:

• Create a branch off of your master branch with these changes,
  for example, "kdump".
• Make a series of related changes in that branch; in our example,
  that would be all of the changes in the kickstart and GUI sections that you've suggested
  for kdump related topics.
• Send a pull request for that set of changes.
• Review and repeat with the next related set of changes.

It will be much easier for us to manage our time investment with smaller pieces, and easier for others to participate in maintaining the document. Please try this approach as you work through the comments.

Just noticed that will fix it up. It's totally outdated.

auto does not auto select a value anymore, except on server.

Yes, New standard no longer uses defaults to using cbc

first off its already explained here: sect-kickstart-commands-installation-environment
secondly it seems well out of place in this section.

It's already thrice mentioned previously .

Notably IBM Systems, this is a RHEL use case NOT Fedora....

Don't see need for a redundant mention of same commands shown just below it . It's akin to a nag bomb.

Per chat in #anaconda, team stated its mostly for RHEL NOT Fedora and is discouraged.

Again was advised this was mostly RHEL NOT Fedora