Few issues/questions after going through master branch at commit 44fceef -

• https://pagure.io/joystick/blob/master/f/joystick/consumers/fedora_messaging_consumer.py#_75 - Even branched and rawhide channels doesn't build AtomicHost image. We only build AH image in updates which are only for Fedora 29 (Fedora-29-updates and Fedora-29-updates-tetsing-*)

• https://pagure.io/joystick/blob/master/f/joystick/consumers/fedora_messaging_consumer.py#_82 - run_pre_release() function name is a bit confusing to me since we are uploading here nightly images too. Maybe something like upload_images() would make more sense

• https://pagure.io/joystick/blob/master/f/joystick/consumers/fedora_messaging_consumer.py#_96 - Similarly for run_release() function, something like mark_images_public() or publish_images() would make more sense

• https://pagure.io/joystick/blob/master/f/joystick/consumers/fedora_messaging_consumer.py#_257 - To keep consistent with existing fedmsg, image.upload should also publish information about "image_name" and "image_url" . See https://apps.fedoraproject.org/datagrepper/id?id=2019-1ac11556-6a23-4e79-a117-52a7c85e3f22&is_raw=true&size=extra-large

• https://pagure.io/joystick/blob/master/f/joystick/consumers/fedora_messaging_consumer.py#_281 - Similarly for image.publish fedmsg, we need to capture image_name and image_url as well. See https://pagure.io/joystick/blob/add-tests/f/joystick/consumers/fedora_messaging_consumer.py#_281

• https://pagure.io/joystick/blob/master/f/joystick/consumers/fedora_messaging_consumer.py#_264 - We should use image['virt_type'] instead of hardcoding 'hvm'

• https://pagure.io/joystick/blob/master/f/Dockerfile#_9 - Isn't just installing mantle-plume package enough?