#22 warning: assignment discards ‘const’ qualifier from pointer target type
Closed: fixed Opened by emaldonado.

This is what we get:

PK11Store.c:841:19: warning: assignment discards const qualifier from pointer target type [-Wdiscarded-qualifiers]
JSSKeyStoreSpi.c:642:20: warning: passing argument 1 of freeObjectNick discards const qualifier from pointer target type [-Wdiscarded-qualifiers]
---------------------------------------------------------------------------
PK11Store.c: In function Java_org_mozilla_jss_pkcs11_PK11Store_importEncryptedPrivateKeyInfo:
PK11Store.c:841:19: warning: assignment discards const qualifier from pointer target type [-Wdiscarded-qualifiers]
     nickItem.data = nicknameChars;
-----------
cc -o Linux4.17_x86_64_glibc_PTH_64_DBG.OBJ/JSSKeyStoreSpi.o -c -g -D_POSIX_SOURCE -D_DEFAULT_SOURCE -D_XOPEN_SOURCE -fPIC -DLINUX2_1  -Wall -Werror-implicit-function-declaration -Wno-switch -pipe -DLINUX -Dlinux -DHAVE_STRERROR -DXP_UNIX -DDEBUG -UNDEBUG -DDEBUG_emaldonado -D_REENTRANT -DUSE_UTIL_DIRECTLY -I../../../../../../../dist/Linux4.17_x86_64_glibc_PTH_64_DBG.OBJ/include -I../../../../../../../dist/public/jss -I../../../../../../../dist/private/jss -I/etc/alternatives/java_sdk_1.8.0_openjdk/include -I/etc/alternatives/java_sdk_1.8.0_openjdk/include/linux -I../../../../../../../dist/public/nspr20 -I../../../../../../../dist/public/nss  -I/etc/alternatives/java_sdk_1.8.0_openjdk/include JSSKeyStoreSpi.c
JSSKeyStoreSpi.c: In function findKeyCallback:
JSSKeyStoreSpi.c:642:20: warning: passing argument 1 of freeObjectNick discards const qualifier from pointer target type [-Wdiscarded-qualifiers]
     freeObjectNick(objNick, type);
                    ^~~~~~~
JSSKeyStoreSpi.c:277:22: note: expected char * but argument is of type const char *
 freeObjectNick(char *nick, TokenObjectType type)
                ~~~~~~^~~~

Triggered by the '-Wdiscarded-qualifiers' uses in building.


This patch fixes the discarded 'const' qualifier warnings.

fixDiscardedConstQualifier.patch

(Edited description for formatting)

This is fixed by jss pr#25. The upstream commit is cf19f3.

Metadata Update from @cipherboy:
- Custom field component adjusted to None
- Custom field feature adjusted to None
- Custom field origin adjusted to None
- Custom field proposedmilestone adjusted to None
- Custom field proposedpriority adjusted to None
- Custom field reviewer adjusted to None
- Custom field type adjusted to None
- Custom field version adjusted to None

Metadata Update from @cipherboy:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

Metadata