Hi @gabrielsclimaco ,

I have a few considerations on this PR:

• A Dockerfile for development seems to be a good idea, thanks :)

• Your branch seems to be a little behind master. Please, rebase it before submitting the patch

• I don't think we need a shell script to run the container. Any thoughts here?

Hey, about your comments:

• As the PR aims branch api I rebased the source branch from api
• I created a shell script for two main reasons:
  • Because the command used to run the docker is very extensive. With a shell script, all it needs to do it's ./run_docker.sh.
  • With a shell script I can document the command used to run the docker.

Thanks for the changes!

• There is no need to add comments describing your programs step-by-step, as you did in the shell script. A programmer should be able to read and understand your code.

• I Still believe that the run_docker.sh script does not add that much value there, it might be confusing, I myself have no intentions to run kiskadee using docker in that way for now. You could do that in a Makefile though: We could move other things there, like building the containers for all the runners (which is a shell script for now).

• Is there any reason for wanting to merge this in the api branch? this could go straight to master.

• There is still some issue with the PR, it still proposes a merge with some other commits, make sure you are applying your changes on HEAD of whatever branch you want us to merge it.

Opened as a new one targeting master https://pagure.io/kiskadee/pull-request/61/