koji

#10 extention handling on hub is broken
Closed: Fixed Opened by ausil.

Closed: Fixed
Reopen Issue

The way that koji hub deals with archive extentions is wrong. it chops off at the last . we have defined in the schema 

insert into archivetypes (name, description, extensions) values ('tar', 'Tar file', 'tar tar.gz tar.bz2 tar.xz');
insert into archivetypes (name, description, extensions) values ('raw-xz', 'xz compressed raw disk image', 'raw.xz');

We really need to get the list of valid extentions and see if the archive ends with one of them.
we have had a task fail because there is two possible archive types ending in .xz http://koji.fedoraproject.org/koji/taskinfo?taskID=12130890

See also: https://fedorahosted.org/koji/ticket/324

possible fix for the query

SELECT id, name, description, extensions FROM archivetypes WHERE extensions ~* E'(\\s|^)%s(\\s|$)'

koji=# SELECT id, name, description, extensions FROM archivetypes WHERE extensions ~* E'(\\s|^)raw.xz(\\s|$)';
 id |  name  |         description          | extensions 
----+--------+------------------------------+------------
 26 | raw-xz | xz compressed raw disk image | raw.xz
(1 row)
koji=# SELECT id, name, description, extensions FROM archivetypes WHERE extensions ~* E'(\\s|^)tar.xz(\\s|$)';
 id | name | description |        extensions         
----+------+-------------+---------------------------
  4 | tar  | Tar files   | tar tar.gz tar.bz2 tar.xz
(1 row)
koji=# SELECT id, name, description, extensions FROM archivetypes WHERE extensions ~* E'(\\s|^)xz(\\s|$)';
 id | name | description | extensions 
----+------+-------------+------------
(0 rows)

That looks like it will work

https://pagure.io/koji/pull-request/11 pulls in your updated query

Merged

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/10

Please continue any further discussion there.
Metadata
None
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.