koji

#1132 TypeError: 'NoneType' object is not callable
Closed: Dropped by tkopecek. Opened by stormi.

Closed: Dropped
Reopen Issue

Using koji 1.16.1 on Mageia 6 with python 3.5, I get errors in koji moshimoshi, but not all the time.

[samuel2@localhost koji]$ koji moshimoshi
bună ziua, kojiadmin!
You are using the hub at https://koji.xcp-ng.org/kojihub
Authenticated via client certificate /home/samuel2/.koji/client.crt
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7f2a56ed5ae8>
Traceback (most recent call last):
  File "/usr/lib64/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
[samuel2@localhost koji]$ koji moshimoshi
yo, kojiadmin!
You are using the hub at https://koji.xcp-ng.org/kojihub
Authenticated via client certificate /home/samuel2/.koji/client.crt
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7f498b74aae8>
Traceback (most recent call last):
  File "/usr/lib64/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
[samuel2@localhost koji]$ koji moshimoshi
back to work, kojiadmin!
You are using the hub at https://koji.xcp-ng.org/kojihub
Authenticated via client certificate /home/samuel2/.koji/client.crt
[samuel2@localhost koji]$ koji moshimoshi
bonjour, kojiadmin!
You are using the hub at https://koji.xcp-ng.org/kojihub
Authenticated via client certificate /home/samuel2/.koji/client.crt
[samuel2@localhost koji]$ koji moshimoshi
bună ziua, kojiadmin!
You are using the hub at https://koji.xcp-ng.org/kojihub
Authenticated via client certificate /home/samuel2/.koji/client.crt
[samuel2@localhost koji]$ koji moshimoshi
hello, kojiadmin!
You are using the hub at https://koji.xcp-ng.org/kojihub
Authenticated via client certificate /home/samuel2/.koji/client.crt
[samuel2@localhost koji]$ koji moshimoshi
안녕하세요, kojiadmin!
You are using the hub at https://koji.xcp-ng.org/kojihub
Authenticated via client certificate /home/samuel2/.koji/client.crt
[samuel2@localhost koji]$ koji moshimoshi
hello, kojiadmin!
You are using the hub at https://koji.xcp-ng.org/kojihub
Authenticated via client certificate /home/samuel2/.koji/client.crt
[samuel2@localhost koji]$ koji moshimoshi
bonjour, kojiadmin!
You are using the hub at https://koji.xcp-ng.org/kojihub
Authenticated via client certificate /home/samuel2/.koji/client.crt
[samuel2@localhost koji]$ koji moshimoshi
ciao, kojiadmin!
You are using the hub at https://koji.xcp-ng.org/kojihub
Authenticated via client certificate /home/samuel2/.koji/client.crt
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7ff97c050ae8>
Traceback (most recent call last):
  File "/usr/lib64/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
[samuel2@localhost koji]$ koji moshimoshi
yo, kojiadmin!
You are using the hub at https://koji.xcp-ng.org/kojihub
Authenticated via client certificate /home/samuel2/.koji/client.crt

Unfortunately there is not much to go on here. My best guess is that this is related to something in the logging module.

I've never encountered this.

3.5 seems like an odd python version to have at this point.

or OpenSSL. That and logging the only things that seem to be using weakref in a quick test here.

I don't suppose you've sorted this out since you filed?

No, it's still present. Any idea to help debug it?

Is this better with current HEAD? I have still never seen this error.

Your past makes it look like this is happening about 1 in 5 times. Is that about right?

When it fails, it still prints the full "Authenticated via client certificate ..." message, which is literally the last thing that handle_moshimoshi() does. Once control passes back to the main script, not much else happens.

  1. it tries to log out the session, but that is wrapped in a broad try..except
  2. it calls sys.exit

My suspicion is that some cleanup handler if failing randomly depending on the order that python de-allocates things as it shuts down.

If it is still happening, see if you can get it to happen with the python debugger on. E.g.

[mike@localhost koji]$ python3 -m pdb /usr/bin/koji -p lkoji hello
> /usr/bin/koji(27)<module>()
-> from __future__ import absolute_import
(Pdb) c
hola, mikem!
You are using the hub at https://localhost/kojihub
Authenticated via client certificate /home/mike/.koji/mikem-local.crt
The program exited via sys.exit(). Exit status: 0
> /usr/bin/koji(27)<module>()
-> from __future__ import absolute_import
(Pdb) q

Of course, the error does not happen for me, but if you can hit it this way, you may be able to poke around a bit.

I don't reproduce with latest HEAD. Actually, I don't reproduce either with tag koji-1.16.1 no matter how many times I try.

This suggests a packaging issue or an issue with the backport of latest koji package in Mageia cauldron towards Mageia 6.

cc @ngompa

I don't reproduce with latest HEAD. Actually, I don't reproduce either with tag koji-1.16.1 no matter how many times I try.

It could also have been a bug in a library that Koji uses, or even in python. I'm curious what it would take to reproduce it, but I'm not sure how much effort is is worth at this point.

I still reproduce with the locally installed koji CLI tool 1.16.1, but I think at this point we should consider it as a distro-specific packaging issue.
Edited by stormi

Metadata Update from @tkopecek:
- Custom field Size adjusted to None
- Issue close_status updated to: Dropped
- Issue status updated to: Closed (was: Open)

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/1132

Please continue any further discussion there.
Metadata
None
None
None
None
Low
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.