Issue #1237: Architectures field in build target uses 2 different separators - koji

koji

#1237 Architectures field in build target uses 2 different separators

Closed: Fixed May 21, 2019 by mikem. Opened Feb 7, 2019 by pbabinca.

Koji returns inconsistent data for architectures from build target, because both space and comma separators are allowed.

Could be possible to unify separators to space character only (at least in API responses)?

Ideally it would be great to get same order of the architectures no matter in which order they have been provided (e.g. sort them alphabetically).

mikem commented Feb 7, 2019

Koji returns inconsistent data for architectures from build target

Where specifically in the api are you seeing this? I need to see the actual problem.

Koji uses space separators for the arch field of tags. There are a few places in the cli (not the api) where a list of arches can be specified with commas because it is the argument of a single option and using commas avoids having to quote the option in shell.

Edited Feb 11, 2019 by mikem

pbabinca commented Feb 8, 2019

You are correct. It has turned out that architecture(s) has been set as x86_64,ppc64le over API and because comma wasn't replaced by space hub has treated this as single architecture.

I guess this bug report can be then closed as invalid.

Metadata Update from @pbabinca:
- Issue close_status updated to: Invalid
- Issue status updated to: Closed (was: Open)

Feb 8, 2019

tkopecek commented Feb 11, 2019

I've seen this already - we probably should introduce some hub-level arch sanitization (comma can't be part of any arch)

Metadata Update from @tkopecek:
- Issue status updated to: Open (was: Closed)

Feb 11, 2019

ktdreyer commented Feb 11, 2019

What characters should be allowed? I'm thinking [a-zA-Z0-9_]

tkopecek commented Feb 13, 2019

Maybe [a-zA-Z0-9_-] ?

tkopecek commented Feb 20, 2019