#1379 tagNotification is broken for deleted tags
Closed: Fixed by tkopecek. Opened by tkopecek.

In some cases (sidetags) tag can be deleted before untag notifications are sent. Such situation results in an exception and rollback.

It could be ok to not send any notification in such case. It is similar to situation when tag is deleted and still contains some builds?


PR #1380

We have a few items, like tags, that can be 'deleted' via versioned data. Calls like getTag will say they're not there, but I wonder if it would make sense to have a way to tell these calls you want the last active version (and some indication of the deletion). Perhaps event="auto"?

A number of uses might benefit from this, such as notifications.

OTOH, just dropping this notifications is easier. Of course the tag could still disappear between the notification trigger and the task execution.

Metadata Update from @tkopecek:
- Custom field Size adjusted to None
- Issue set to the milestone: 1.20

Commit 9ac3fa7c fixes this issue

Commit f0aa13bf fixes this issue

Metadata Update from @jcupova:
- Issue tagged with: testing-done

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/1379

Please continue any further discussion there.

Metadata
Related Pull Requests